Conversation
Member
Author
dervoeti
reviewed
Jan 19, 2026
Member
dervoeti
left a comment
There was a problem hiding this comment.
Nice, just a few nits.
Also: As far as I see it the integration test currently does not validate whether an action is denied by OPA, only that sending/receiving messages succeed. Maybe we should test some action that would be denied? Because currently, at least in theory, the test would also succeed if the OPA config is ignored for some reason and all actions are allowed by default.
Member
Author
|
I've extended the test to filter on topic names so that we can also test that there is no access to a disallowed topic: --- PASS: kuttl (111.42s)
--- PASS: kuttl/harness (0.00s)
--- PASS: kuttl/harness/opa_kafka-latest-3.9.1_zookeeper-latest-3.9.4_opa-latest-1.8.0_use-opa-tls-false_openshift-false_krb5-1.21.1 (101.45s)
--- PASS: kuttl/harness/opa_kafka-latest-3.9.1_zookeeper-latest-3.9.4_opa-latest-1.8.0_use-opa-tls-true_openshift-false_krb5-1.21.1 (110.51s)
PASS |
dervoeti
reviewed
Jan 19, 2026
Co-authored-by: Lukas Krug <[email protected]>
dervoeti
approved these changes
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #534
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker