-
-
Notifications
You must be signed in to change notification settings - Fork 4
feat: config overrides #818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dervoeti
wants to merge
9
commits into
main
Choose a base branch
from
feat/config-overrides
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
8210a9f
feat: config overrides
dervoeti 797698e
chore: changelog
dervoeti 33c4462
Update rust/operator-binary/src/controller.rs
dervoeti 1dc457d
Update rust/operator-binary/src/controller.rs
dervoeti a75fa14
fix: address review feedback
dervoeti 5feaa82
feat: daemonset maxsurge to prevent unavailability on config changes …
dervoeti 899baa2
chore: Generated commit to update templated files since the last temp…
stackable-bot a4286be
Merge branch 'main' into feat/config-overrides
dervoeti ef8ba50
refactor: mention role overrides first
dervoeti File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,30 +1,19 @@ | ||
| = OpenTelemetry | ||
| :description: Ship OPA traces and logs to OpenTelemetry | ||
| :opa-docs: https://v1-4-2--opa-docs.netlify.app/configuration/#distributed-tracing | ||
| :opa-docs: https://www.openpolicyagent.org/docs/configuration/#distributed-tracing | ||
|
|
||
| Opa supports sending OpenTelemetry traces as stated in {opa-docs}[the documentation]. | ||
| OPA supports sending OpenTelemetry traces as stated in {opa-docs}[the documentation]. | ||
|
|
||
| As of SDP 25.7, `configOverrides` are (still) not supported, we are tracking the progress in https://github.com/stackabletech/opa-operator/issues/756[this GitHub issue]. | ||
| To enable traces you need to modify the config and thus xref:opa:usage-guide/operations/cluster-operations.adoc[pause the reconciliation] of your OpaCluster, so that changes to the ConfigMap aren't immediately overridden by the opa-operator. | ||
|
|
||
| WARNING: It's not encouraged to pause the reconciliation more than just temporarily. We recommend disabling it while you debug e.g. performance problems and re-enabling it afterwards. This problem will be solved once we support configOverrides for OPA. | ||
|
|
||
| Afterwards you can edit the `<stacklet-name>-server-default` ConfigMap and append a `distributed_tracing` section as follows. | ||
| To enable traces, add a `distributed_tracing` section to the OPA configuration using `configOverrides`. | ||
| Please check the {opa-docs}[OPA documentation] to see what other settings you can configure. | ||
|
|
||
| [source,yaml] | ||
| ---- | ||
| apiVersion: v1 | ||
| kind: ConfigMap | ||
| metadata: | ||
| name: opa-server-default | ||
| data: | ||
| config.json: |- | ||
| { | ||
| <<< existing JSON >>> | ||
| "distributed_tracing": { | ||
| "address": "jaeger-collector.default.svc.cluster.local:4317", | ||
| "type": "grpc" | ||
| } | ||
| } | ||
| servers: | ||
| configOverrides: | ||
| config.json: | ||
| jsonMergePatch: | ||
| distributed_tracing: | ||
| address: jaeger-collector.default.svc.cluster.local:4317 | ||
| type: grpc | ||
| ---- | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.