Skip to content

Conversation

@labrenbe
Copy link
Member

@labrenbe labrenbe commented Nov 21, 2025

Description

Allow referencing Secret keys in the OpenSearch config to add them as entries to the OpenSearch keystore.

Part of #44.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Release Notes

Allow adding secrets to the OpenSearch keystore, e.g. S3 credentials for creating and restoring backups.

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@labrenbe labrenbe self-assigned this Nov 21, 2025
@labrenbe labrenbe moved this to Development: In Progress in Stackable Engineering Nov 21, 2025
@labrenbe labrenbe marked this pull request as ready for review November 21, 2025 10:36
@labrenbe labrenbe moved this from Development: In Progress to Development: Waiting for Review in Stackable Engineering Nov 21, 2025
@siegfriedweber siegfriedweber mentioned this pull request Dec 2, 2025
3 tasks
@siegfriedweber siegfriedweber moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Dec 3, 2025
Copy link
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@labrenbe labrenbe added this pull request to the merge queue Dec 11, 2025
Merged via the queue into main with commit 5aaeb94 Dec 11, 2025
12 checks passed
@labrenbe labrenbe deleted the feat/snapshot-s3 branch December 11, 2025 12:50
@siegfriedweber siegfriedweber moved this from Development: In Review to Development: Done in Stackable Engineering Dec 12, 2025
@lfrancke
Copy link
Member

Should this be mentioned in the release notes?

@lfrancke lfrancke moved this from Development: Done to Acceptance: In Progress in Stackable Engineering Dec 15, 2025
@labrenbe
Copy link
Member Author

I've added a release notes section to the issue.

@siegfriedweber siegfriedweber added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Dec 19, 2025
@lfrancke
Copy link
Member

Can you explain what this would be used for? Why do we need this?

@lfrancke lfrancke moved this from Acceptance: In Progress to Done in Stackable Engineering Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release/26.3.0 release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

Development

Successfully merging this pull request may close these issues.

4 participants