chore: Describe RBAC rules, remove unnecessary rules#869
Open
NickLarsenNZ wants to merge 12 commits intomainfrom
Open
chore: Describe RBAC rules, remove unnecessary rules#869NickLarsenNZ wants to merge 12 commits intomainfrom
NickLarsenNZ wants to merge 12 commits intomainfrom
Conversation
18 tasks
NickLarsenNZ
commented
Apr 2, 2026
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
…clusterrole Not needed for CRD maintenance
… product clusterrole Product pods will have necessary secrets/configmaps mounted and not directly talk to Kubernetes
Required for startup condition
The operator takes care of events
…close to each other
…tor.yaml and clusterrole-product.yaml
Member
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of stackabletech/issues#798
Note
This was initially generated by a coding assistant to see how well it can inspect code and review the RBAC rules. the changes will be properly checked before reviews are requested.
Operator ClusterRole - removed rules/verbs
opa.stackable.tech/regorules(entire rule) - OPA Rego rules are not used by the Trino operatornodeslist/watch (entire rule) - not needed; onlynodes/proxyget is required for cluster domain detectionpodsfrom core resources - operator does not manage Pod resources directly (StatefulSets manage pods)endpointsfrom core resources - not used by the operatorbatch/jobs(entire rule) - Trino operator does not create Jobsupdateverb from configmaps, services, serviceaccounts, rolebindings, statefulsets, poddisruptionbudgets - SSA usespatch, notupdatewatchverb from serviceaccounts, rolebindings, poddisruptionbudgets - these resources are not watched by the controllerdelete/list/watchfromsecrets- secrets are managed via direct get/apply_patch, not via cluster_resources; no orphan cleanup or watch neededgetverb fromcustomresourcedefinitions- not needed (only list/watch for startup, create/patch for maintenance)watchfromlisteners- listeners are not watched by the controllerpatchfromtrinoclustersmain resource - only read access needed (get/list/watch); status updates use the/statussubresourceProduct ClusterRole - removed rules/verbs
configmaps/secrets/serviceaccountsget (entire rule) - Trino pods do not need to read these resources directlyevents.k8s.io/eventscreate/patch (entire rule) - events are emitted by the operator controller, not by the Trino product pods