application load balancer controller for ingress objects#3
Merged
Conversation
ske-prow
Bot
added
do-not-merge/needs-kind
nschad
changed the title
ske-prow
Bot
added
the
do-not-merge/work-in-progress
Contributor
|
@fischerman either mark the PR as "Draft" or use "WIP" as the title. The PR will then automatically marked as WIP/Draft |
ske-prow
Bot
added
the
needs-rebase
ske-prow
Bot
removed
the
needs-rebase
fischerman
commented
Jun 26, 2026
Adi146
reviewed
Jun 26, 2026
dergeberl
reviewed
Jun 26, 2026
dergeberl
left a comment
dergeberl
left a comment
Member
There was a problem hiding this comment.
This is my first batch of review comments. Only had a look into the /cmd/*, /pkg/controller/* (except the tests) and the *.md files, yet. I will continue with my review for the rest.
Maybe some comments are already resolved as you also pushed during my review (I did not crosscheck again, before submitting the comments now).
dergeberl
reviewed
Jun 29, 2026
dergeberl
left a comment
dergeberl
left a comment
Member
There was a problem hiding this comment.
Comments for the stackit package and testutil
hown3d
reviewed
Jun 29, 2026
dergeberl
reviewed
Jun 29, 2026
dergeberl
reviewed
Jun 29, 2026
dergeberl
reviewed
Jun 29, 2026
dergeberl
reviewed
Jun 29, 2026
dergeberl
reviewed
Jun 30, 2026
dergeberl
reviewed
Jun 30, 2026
dergeberl
reviewed
Jun 30, 2026
dergeberl
reviewed
Jun 30, 2026
ftl
reviewed
Jun 30, 2026
ftl
reviewed
Jun 30, 2026
dergeberl
reviewed
Jun 30, 2026
Contributor
|
/kind enhancement |
dergeberl
reviewed
Jul 14, 2026
dergeberl
reviewed
Jul 15, 2026
Allow controller to run in Gardener in kube-system namespace
dergeberl
reviewed
Jul 16, 2026
dergeberl
changed the title
ske-prow
Bot
removed
the
do-not-merge/work-in-progress
dergeberl
approved these changes
Jul 16, 2026
|
LGTM label has been added. DetailsGit tree hash: 454687d5f200d7d19b005f53a09ea2d21528bfca |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dergeberl The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ske-prow
Bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/kind enhancement
What this PR does / why we need it:
Implements the first alpha version of the STACKIT ALB controller for ingress obejcts