display projects correctly by using resource manager tree #1155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hown3d
changed the title
Signed-off-by: Lukas Hoehl <[email protected]> split into files Signed-off-by: Lukas Hoehl <[email protected]>
Signed-off-by: Lukas Hoehl <[email protected]>
hown3d
force-pushed
the
project-list-v3
branch
from
4e92522 to
1ff8fb7
Compare
Signed-off-by: Lukas Hoehl <[email protected]>
Signed-off-by: Lukas Hoehl <[email protected]>
Signed-off-by: Lukas Hoehl <[email protected]>
hown3d
force-pushed
the
project-list-v3
branch
from
1ff8fb7 to
03fbbbc
Compare
Signed-off-by: Lukas Hoehl <[email protected]>
|
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
Member
Author
|
Would love to know your opinion :) @stackitcloud/developer-tools |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current implementation of the
project listcommand does not return all projects a user has permission to see. It just returns the projects a user is directly a member of, not if he inherited the permissions from e.g. an organization or folder.This PR uses the authorization and resourcemanager APIs to correctly query all projects a user has permission to see.
The implementation is a tree based data structure that uses recursion to view all projects of a folder, nested folders and projects directly under a organization.
For printing the Organization name, as well as the folder path is additionally printed. I decided against querying the resourcemanager API for project details as that returned in 500's from the API if queried to fast.
The existing flag filters do not apply as good anymore to the implementation, so they could be removed if the implementation itself is accepted.
Tests will be implemented once a first review has been done, as this also takes some time. I tested the change manually.
Checklist
make fmtmake generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)