Refac/stackittpr 229 provider config builder#1313
Open
cgoetz-inovex wants to merge 5 commits intomainfrom
Open
Refac/stackittpr 229 provider config builder#1313cgoetz-inovex wants to merge 5 commits intomainfrom
cgoetz-inovex wants to merge 5 commits intomainfrom
Conversation
- sets region eu01 by default - sets custom endpoints from env vars by default - sets enable beta resoures by default - replace client configuration in acc tests with ConfigBuilder - use ConfigBuilder for provider snippet funcs
- resourcemanager inlined manually - add empty line after provider config
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
rubenhoenle
reviewed
Mar 19, 2026
| func NewConfigBuilder() *ConfigBuilder { | ||
| b := &ConfigBuilder{ | ||
| region: "eu01", | ||
| enableBetaResources: true, |
Member
There was a problem hiding this comment.
Do we really want to have beta resources enabled by default?
Should be exactly the other way around from my understanding.
Contributor
Author
There was a problem hiding this comment.
The original was opt-in to beta resources, used true here to save us some configuring in tests.
Is there a downside to this?
Member
There was a problem hiding this comment.
Since the beta resources aren't enabled by default in our provider by default I would expect the same in the test suite.
But I'm a general opt-in guy I would say xD
rubenhoenle
reviewed
Mar 25, 2026
| opts = append(opts, sdkConf.WithTokenEndpoint(tokenEndPoint)) | ||
| } | ||
| if b.region != "" { | ||
| opts = append(opts, sdkConf.WithRegion(b.region)) |
Member
There was a problem hiding this comment.
Actually the WithRegion is only needed for a subset of services.
You could even get an error for global APIs if you call it.
Member
There was a problem hiding this comment.
So I think it has to stay out of here
rubenhoenle
reviewed
Mar 25, 2026
| provider "stackit" { | ||
| default_region = "eu01" | ||
| }` | ||
| func (b *ConfigBuilder) BuildClientOptions(service customEndpointConfig) []sdkConf.ConfigurationOption { |
Member
There was a problem hiding this comment.
Pretty nice one btw, thanks for that! 😊
rubenhoenle
approved these changes
Mar 25, 2026
Member
rubenhoenle
left a comment
rubenhoenle
left a comment
There was a problem hiding this comment.
See comments above, rest looks great
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
relates to #1234
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)