feat(ske): support audit log configuration - #1578
feat(ske): support audit log configuration#1578tobias-pfaffelmoser-ske wants to merge 8 commits into
Conversation
52f7b99 to
2160dd9
Compare
rubenhoenle
left a comment
There was a problem hiding this comment.
As written in the PR template checklist, the Acceptance tests / E2E tests need to be adjusted to include your new field: ske_acc_test.go
Min test
In the min test only required fields must be set in the test configuration.
Since your field is optional you only have to add checks that the new field has the correct default value.
terraform-provider-stackit/stackit/internal/services/ske/ske_acc_test.go
Lines 120 to 265 in e45f2f5
Max test
For the Max test you have to add your field to the Terraform config:
Afterwards add a new variable for your field:
Also update the field to test not only the create operation but also the update operation:
terraform-provider-stackit/stackit/internal/services/ske/ske_acc_test.go
Lines 110 to 118 in e45f2f5
Then add the checks for your new field to the text steps:
terraform-provider-stackit/stackit/internal/services/ske/ske_acc_test.go
Lines 267 to 509 in e45f2f5
2160dd9 to
54be3c6
Compare
rubenhoenle
left a comment
There was a problem hiding this comment.
Looks good besides that ✔️
8862ef0 to
28cee91
Compare
2ba818f to
c24acbe
Compare
|
@tobias-pfaffelmoser-ske could you please resolve the conflicts so we can merge this? 😅 |
Description
Adds support for configuring SKE cluster audit log forwarding via a new optional
auditblock on thestackit_ske_clusterresource (and as a read-only attributeon the data source):
The audit.enabled flag is passed through to the SKE API (ske.Audit) on create/update and mapped back into state on read. This feature is in private preview and can only be enabled for accounts/projects that have been enabled for audit log forwarding to a Telemetry Router.
This also bumps the stackit-sdk-go/services/ske dependency to v1.19.0, which introduces the audit field.
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)