feat(telemetrylink): Add write only attributes for accessToken - #1657
Open
Fyusel wants to merge 1 commit into
Open
feat(telemetrylink): Add write only attributes for accessToken#1657Fyusel wants to merge 1 commit into
Fyusel wants to merge 1 commit into
Conversation
STACKITTPR-751 Signed-off-by: Alexander Dahmen <alexander.dahmen@inovex.de>
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
rubenhoenle
reviewed
Aug 4, 2026
| DisplayName: planModel.DisplayName.ValueStringPointer(), | ||
| // description is Optional, so it must be sent as an explicit "" instead of | ||
| // being omitted when cleared | ||
| Description: tfutils.StringPointerOrEmpty(planModel.Description), |
Member
There was a problem hiding this comment.
Suggested change
| Description: tfutils.StringPointerOrEmpty(planModel.Description), | |
| Description: new(planModel.Description.ValueString()), |
I would prefer to not have this new util function because you can easily do this inline in a readable way.
rubenhoenle
reviewed
Aug 4, 2026
|
|
||
| return &telemetrylink.PartialUpdateFolderTelemetryLinkPayload{ | ||
| DisplayName: planModel.DisplayName.ValueStringPointer(), | ||
| Description: tfutils.StringPointerOrEmpty(planModel.Description), |
Member
There was a problem hiding this comment.
Suggested change
| Description: tfutils.StringPointerOrEmpty(planModel.Description), | |
| Description: new(planModel.Description.ValueString()), |
same here
rubenhoenle
reviewed
Aug 4, 2026
|
|
||
| return &telemetrylink.PartialUpdateProjectTelemetryLinkPayload{ | ||
| DisplayName: planModel.DisplayName.ValueStringPointer(), | ||
| Description: tfutils.StringPointerOrEmpty(planModel.Description), |
Member
There was a problem hiding this comment.
Suggested change
| Description: tfutils.StringPointerOrEmpty(planModel.Description), | |
| Description: new(planModel.Description.ValueString()), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
STACKITTPR-751
Description
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)