Skip to content

Conversation

@aaronb-stacks
Copy link
Contributor

This PR adds some docs for how we should handle property testing in this repo going forward, and it includes an example property test for the make_reward_set function.

@aaronb-stacks aaronb-stacks requested review from a team October 30, 2025 15:13
@CLAassistant
Copy link

CLAassistant commented Oct 30, 2025

CLA assistant check
All committers have signed the CLA.

brice-stacks
brice-stacks previously approved these changes Dec 12, 2025
Copy link
Contributor

@brice-stacks brice-stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but there are some clippy issues preventing the tests from running.

jcnelson
jcnelson previously approved these changes Dec 12, 2025
Copy link
Member

@jcnelson jcnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; just please add copyright comment blocks 🙏

@codecov
Copy link

codecov bot commented Dec 12, 2025

Codecov Report

❌ Patch coverage is 42.85714% with 112 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.14%. Comparing base (3da96c1) to head (9c6a2ff).

Files with missing lines Patch % Lines
...tackslib/src/chainstate/stacks/tests/reward_set.rs 28.08% 105 Missing ⚠️
stacks-node/src/tests/signer/v0.rs 0.00% 7 Missing ⚠️

❌ Your project check has failed because the head coverage (68.14%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (3da96c1) and HEAD (9c6a2ff). Click for more details.

HEAD has 21 uploads less than BASE
Flag BASE (3da96c1) HEAD (9c6a2ff)
88 67
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #6640       +/-   ##
============================================
- Coverage    78.18%   68.14%   -10.04%     
============================================
  Files          580      582        +2     
  Lines       361096   361289      +193     
============================================
- Hits        282312   246208    -36104     
- Misses       78784   115081    +36297     
Files with missing lines Coverage Δ
stackslib/src/chainstate/stacks/tests/mod.rs 77.24% <ø> (-3.71%) ⬇️
stackslib/src/lib.rs 100.00% <ø> (ø)
stackslib/src/proptest_utils.rs 100.00% <100.00%> (ø)
stacks-node/src/tests/signer/v0.rs 14.83% <0.00%> (-6.50%) ⬇️
...tackslib/src/chainstate/stacks/tests/reward_set.rs 28.08% <28.08%> (ø)

... and 339 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3da96c1...9c6a2ff. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants