-
Notifications
You must be signed in to change notification settings - Fork 723
Property Tests: make_reward_set proptest and documentation #6640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Property Tests: make_reward_set proptest and documentation #6640
Conversation
* force duplication
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but there are some clippy issues preventing the tests from running.
jcnelson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; just please add copyright comment blocks 🙏
9c6a2ff
Codecov Report❌ Patch coverage is
❌ Your project check has failed because the head coverage (68.14%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.
Additional details and impacted files@@ Coverage Diff @@
## develop #6640 +/- ##
============================================
- Coverage 78.18% 68.14% -10.04%
============================================
Files 580 582 +2
Lines 361096 361289 +193
============================================
- Hits 282312 246208 -36104
- Misses 78784 115081 +36297
... and 339 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This PR adds some docs for how we should handle property testing in this repo going forward, and it includes an example property test for the
make_reward_setfunction.