Skip to content

Conversation

@brice-stacks
Copy link
Contributor

This removes the v1 parser. We'll need to verify that block validation or genesis sync still works with this change in place.

@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

❌ Patch coverage is 96.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 72.61%. Comparing base (8826d5c) to head (88c593d).
⚠️ Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
clarity/src/vm/ast/mod.rs 88.88% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6754      +/-   ##
===========================================
- Coverage    76.58%   72.61%   -3.97%     
===========================================
  Files          580      579       -1     
  Lines       361096   360363     -733     
===========================================
- Hits        276555   261695   -14860     
- Misses       84541    98668   +14127     
Files with missing lines Coverage Δ
...ity/src/vm/analysis/type_checker/v2_1/tests/mod.rs 90.34% <ø> (-9.42%) ⬇️
clarity/src/vm/ast/definition_sorter/tests.rs 100.00% <100.00%> (ø)
clarity/src/vm/tests/contracts.rs 100.00% <100.00%> (ø)
stackslib/src/chainstate/stacks/db/transactions.rs 87.94% <100.00%> (-9.01%) ⬇️
stackslib/src/chainstate/tests/mod.rs 76.09% <ø> (-1.85%) ⬇️
stackslib/src/net/api/callreadonly.rs 91.21% <100.00%> (ø)
stackslib/src/net/api/fastcallreadonly.rs 91.28% <100.00%> (ø)
stackslib/src/net/api/getconstantval.rs 41.93% <100.00%> (-50.00%) ⬇️
stackslib/src/net/api/getdatavar.rs 88.97% <100.00%> (ø)
stackslib/src/net/api/getistraitimplemented.rs 92.07% <100.00%> (+0.19%) ⬆️
... and 4 more

... and 282 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8826d5c...88c593d. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jacinta-stacks
Copy link
Contributor

Definitely got a lot of failing unit tests. I assume related to trying ot call non existent parser v1 code and defaultint to the new so error types are prob diff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants