Conversation
Collaborator
|
Talking to Bob this was the signature we wanted. The zip as written in the doc would need a to_vector |
Member
Author
|
That would depend on how the indexing operation was written in stan, no? At the very least, this function should not be called |
Collaborator
|
If we returned a tuple of indices I just don't see how we would write something that would be more optimal than just writing the for loop. I think calling it flatten or zip_index would make sense |
Collaborator
|
Making the new pr rn closing this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #3411
I think this was a misreading of the request in stan-dev/stanc3#1704.
The zip function described in that issue would construct an array of pairs, as is common in every other language. The code to then index a matrix with an array of pairs should live in stan-dev/stan not stan-dev/math.