Conversation
Member
Author
|
Cool, thanks for the quick review |
jgabry
enabled auto-merge
September 24, 2026 17:32
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3414.
When
TBB_LIBis set,make/compiler_flagsadds-Wl,--disable-new-dtagson every OS except macOS. On Windows both Rtools linkers reject it and every link
against an external TBB fails.
Noticed this when working on stan-dev/cmdstanr#1286.
Tests
There's no new test. The change is to the makefiles only, and CI doesn't
set
TBB_LIBon Windows.I had Claude check the resulting flags by including
make/compiler_flagsin asmall makefile and printing
LDFLAGS_TBBwithTBB_LIB=/x/lib:Side Effects
I don't think so. Linux and macOS get the same flags as before, and there's no effect for Windows
builds that don't set
TBB_LIB.Release notes
Setting
TBB_LIBon Windows no longer adds--disable-new-dtags, whichthe MinGW linkers reject.
Checklist
(I left some of the boxes unchecked since this is just a makefile change)
Copyright holder: Jonah Gabry
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)
the basic tests are passing
./runTests.py test/unit)make test-headers)make test-math-dependencies)make doxygen)make cpplint)the code is written in idiomatic C++ and changes are documented in the doxygen
the new changes are tested