Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1494 +/- ##
==========================================
+ Coverage 89.52% 89.55% +0.02%
==========================================
Files 66 66
Lines 9684 9695 +11
==========================================
+ Hits 8670 8682 +12
+ Misses 1014 1013 -1
🚀 New features to boost your workflow:
|
Member
Author
|
The expression test failures are kind of weird but they seem to be fixed by stan-dev/math#3147 so there might just be some known bug in offset_multipliers code (cc @SteveBronder) |
SteveBronder
approved these changes
Mar 18, 2025
Contributor
SteveBronder
left a comment
There was a problem hiding this comment.
I have a few small comments but overall I think good!
SteveBronder
approved these changes
Mar 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1436
Submission Checklist
Release notes
All the built-in constraint types now have corresponding
_jacobian,_constrain, and_unconstrainfunctions. The first two functions are identical except for the _jacobian version will increment the target with the necessary change of variables adjustment.Copyright and Licensing
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)