[6.x] Avoid squashed Combobox options near viewport edge #13452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncanmcclean
changed the title
duncanmcclean
changed the title
jasonvarga
added a commit
that referenced
this pull request
Jan 7, 2026
)" This reverts commit 3d3e1ec.
Member
|
I reverted this in #13461. We should find an alternative. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request attempts to fix an issue with the Combobox dropdown where it could be squashed the near the viewport edge, instead of alternating to the opposite position.
This PR fixes it by adding a
min-heightto the dropdown's content and reducing the spacing between the top/bottom of the dropdown and the edge of the viewport.Fixes #13365
Before
CleanShot.2026-01-07.at.12.29.52.mp4
After
CleanShot.2026-01-07.at.12.29.03.mp4