[6.x] Theme text color corrections #13468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e when the theme changes the text color
…mes a lot when they change text colors
…hen they change text colors, without affecting the legibility of the default theme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #13441.
There were many instances where
text-blackortext-grey-950were being used, which was great for the default theme, but as soon as you start customising the theme text colour, the difference between colored text and the950value is jarring.Here are a couple of examples, where you get coloured text vs what is essentially black:
Before
The title here
And the labels here
After
Using the custom value of
925for text helps bring through the theme colour a lot since it's not quite as black. However, the default theme retains almost exactly the same contrast value.Labels and the sidebar look much better