docs: propagate recent develop fixes to sibling packages#12400
Merged
Conversation
Propagates fix from faef343 ("style: use explicit float literal in `stats/base/dists/gumbel/cdf`") to sibling Student's t distribution factory functions, applying the convention of using `0.0` rather than bare `0` when comparing continuous-valued parameters.
Propagates fix from 2bab6a4 ("docs: fix missing header") to sibling package READMEs whose ```c usage examples reference stdint fixed-width integer types (`int8_t`, `int32_t`, `int64_t`) without the corresponding `<stdint.h>` header. Limited to runnable usage examples; function signature blocks and reference-only type definitions are excluded.
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
…clude
Reverts the `<stdint.h>` additions from the previous commit for code
blocks whose project headers already pull in `<stdint.h>` transitively
(`ndarray/{ctor,base/shape2strides,base/function-object}` via their
respective public headers; `stats/base/dists/binomial/mgf` via
`mgf.h`). Those additions were stylistic rather than corrective, and
the larger of them (`ndarray/ctor`, `ndarray/base/shape2strides`)
inflated the affected-tests dependency set to ~2k packages, surfacing
pre-existing test failures unrelated to this propagation.
Retained sites are usage examples whose blocks include no header that
transitively defines stdint types — matching the source commit's
exact pattern.
kgryte
approved these changes
May 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Propagating fixes merged to
developbetweenb9dbd3e3(2026-05-30 15:16 -0500) and15f6a2c0d(2026-05-31 07:04 -0500) to sibling packages with the same underlying defect.Pattern: explicit float literal in continuous-parameter guards in
stats/base/dists/t/*factoriesfaef34302changedbeta <= 0tobeta <= 0.0instats/base/dists/gumbel/cdf/lib/factory.jsto enforce the explicit-float-literal convention for continuous-parameter guard checks. The same bare-integer comparison guards the degrees-of-freedom parametervint/pdfandt/logpdf; sibling t-distribution files (t/cdf,t/logcdf,t/quantile) already use0.0, so this aligns the remaining two.faef34302(style: use explicit float literal in stats/base/dists/gumbel/cdf)@stdlib/stats/base/dists/t/pdf@stdlib/stats/base/dists/t/logpdfPattern: add missing
<stdint.h>includes to C usage examples in READMEs2bab6a4badded#include <stdint.h>to two C usage-example code blocks inblas/ext/base/dmskrev/README.mdthat declareduint8_t mask[]without the header that defines the type. The same defect — a ```c usage-example code block referencingint8_t/`int32_t`/`int64_t` without including `<stdint.h>` — appears in 13 other usage-example blocks across `math/base/napi/quaternary`, `stats/base/dists/binomial/mgf`, and seven `ndarray/base/*` packages plus `ndarray/ctor`. Each insertion is placed in the existing include block in sorted position (between project `"..."` headers and `<stdlib.h>`/`<stdio.h>`), matching the placement convention already used in sibling blocks of the same file.2bab6a4b(docs: fix missing header)@stdlib/math/base/napi/quaternary(two blocks)@stdlib/stats/base/dists/binomial/mgf@stdlib/ndarray/base/flatten-shape-from@stdlib/ndarray/base/flatten-shape@stdlib/ndarray/base/function-object(three blocks)@stdlib/ndarray/base/minmax-view-buffer-index@stdlib/ndarray/base/nonsingleton-dimensions@stdlib/ndarray/base/shape2strides@stdlib/ndarray/base/singleton-dimensions@stdlib/ndarray/ctorRelated Issues
None.
Questions
No.
Other
Validation
Reviewed the 18 fix-class commits (
fix/docs/chore/test/style/perf) merged todevelopin the 24-hour window. Two propagatable source patterns advanced to the patch stage; per-pattern search scope and validation procedure:stats/base/dists/*/lib/factory.jsfor the float-literal style, README C-code blocks underblas/,lapack/,math/,stats/,ndarray/,random/for the missing-include pattern), and exhaustive within those scopes.<stdint.h>lands in sorted position rather than at the block top.Deliberately excluded:
ndarray/base/function-object/README.mdlines 230-232 and 360-362) and the `ndarrayFunctionObject` struct definition block (lines 110-136): the source commit's pattern targets runnable usage examples, not API signatures or type definitions.<inttypes.h>(ndarray/base/{flatten-shape-from,flatten-shape,minmax-view-buffer-index,nonsingleton-dimensions,shape2strides,singleton-dimensions}/README.mdexamples sections): POSIX guarantees<inttypes.h>transitively includes<stdint.h>, so there is no compile-time defect and the addition would be purely cosmetic."auxilary"keyword fix fromb9dbd3e3("chore: remove misspelled keyword"): exhaustive grep confirmed no remaining occurrences in the repository after the source commit.main()-JSDoc fix from7719ac8d("docs: fix missing function description"): exhaustive scan of all 2002 benchmark files under@stdlib/blasconfirmed no remaining sites missing the JSDoc block.003cb6ecand4f28e691(array/float16/lib/polyfill/index.js): single-package wording changes with no sibling-package signature.78f0c534,9d352486,1c951503,fe7c2746,313aca0c): generator-owned files or already-broad cleanup waves not amenable to mechanical propagation.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code on behalf of @Planeshifter as an automated propagation of fixes merged to
developover the prior 24 hours. Candidate source commits were filtered for generalizable patterns, sibling sites located via grep-able pattern signatures, and each proposed patch independently validated by parallel reviewer agents (two opus validation passes plus a sonnet style-consistency pass) before commits were applied in the primary worktree. A human will audit and promote the PR out of draft.@stdlib-js/reviewers
Generated by Claude Code