Conversation
Replace relative tolerance assertions in the `stats/kde2d` tests with ULP-based assertions using `@stdlib/assert/is-almost-same-value`. ULP bounds were tightened to the measured minimum which passes over the full fixture set. Ref: #11352 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012oJYd2qY2kvRKBr7pDJbkz
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
stats/kde2dfrom relative tolerance assertions (delta <= tol, wheretol = N * EPS * abs( expected )) to ULP-based assertions using@stdlib/assert/is-almost-same-value.@stdlib/constants/float64/epsand@stdlib/math/base/special/absrequires and the associateddelta/tolscratch variables.Only
test/test.jsis modified; the package has notest/test.native.js. No implementation, fixture, or documentation files are touched.ULP bounds
Each bound is the measured minimum which passes over the full fixture set. The minima were computed directly from
@stdlib/number/float64/base/ulp-differenceacross every fixture element and then confirmed empirically by re-running the suite atN-1, which fails in each case:N-1resultx200.0 * EPS0y200.0 * EPS0z1500.0 * EPS43x500.0 * EPS0y200.0 * EPS0z2000.0 * EPS2827x250.0 * EPS0y500.0 * EPS0z2000.0 * EPS1716The
xandygrid values match the R reference fixtures exactly, hence a bound of0.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
make test TESTS_FILTER=".*/stats/kde2d/.*"passes: 2098/2098 assertions, matching the assertion count before the migration. The suite was run twice at the final ULP values to confirm the results are deterministic.eslint --config etc/eslint/.eslintrc.tests.jsreports no errors for the modified file.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code as part of an automated, unattended migration task: it selected the package, mirrored the conversion idiom from previously merged
stats/*ULP migrations, measured the minimum ULP bounds, and verified the suite locally.@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_012oJYd2qY2kvRKBr7pDJbkz
Generated by Claude Code