test: migrate stats/base/dists/binomial/kurtosis to ULP-based assertions - #15345
Draft
Planeshifter wants to merge 1 commit into
Draft
Planeshifter wants to merge 1 commit into
Planeshifter wants to merge 1 commit into
Conversation
…tions Resolves a part of #11352. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NbgTEygiUMqVkNd2aUhcoU --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
Member
Author
|
An automated check found potentially unrelated issue/PR references in this PR:
Why this matters: GitHub automatically closes issues referenced with What to do:
This assessment was generated by an AI model and is informational only. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
stats/base/dists/binomial/kurtosisfrom relative tolerance testing to ULP difference testing, replacing theabs( y - expected[i] ) <= tolcomparisons with@stdlib/assert/is-almost-same-value. The idiom mirrors the already-migrated sibling packagestats/base/dists/binomial/entropy.Files changed:
test/test.jsandtest/test.native.js. No non-test files are modified, and no test fixtures, expected values, or test cases were added, removed, or altered.Every fixture-driven comparison in this package resolves exactly (
ULP = 0), for both the JavaScript and native implementations, even though the original tolerance code allowed1.0 * EPS(JS) and30.0 * EPS(native).tolmultipliertest/test.js1.0 * EPStest/test.native.js30.0 * EPSRelated Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
The bound was measured directly, not just probed via test runs: for every fixture, the actual output was computed by requiring the package's
lib/main.js(JS) andlib/native.js(compiled native add-on, built locally viamake install-node-addons NODE_ADDONS_PATTERN="stats/base/dists/binomial/kurtosis") implementations directly and diffing against the expected fixture values with@stdlib/number/float64/base/ulp-difference; the maximum observed ULP difference was0across all 200 fixtures for both implementations. The full test suite (test/test.js,test/test.native.js) was then run twice atULP = 0with identical, fully passing results (214 and 210 assertions respectively), confirming determinism.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code, running as a scheduled/automated session. The migration follows the idiom established in the already-migrated
stats/base/dists/binomial/entropy, and the ULP bounds were measured empirically (via direct ULP-difference computation against the fixtures for both the JS and native implementations) rather than guessed.@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_01NbgTEygiUMqVkNd2aUhcoU
Generated by Claude Code