-
-
Notifications
You must be signed in to change notification settings - Fork 1k
feat: add ndarray/flatten-from-by
#9040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: passed
- task: lint_package_json
status: passed
- task: lint_repl_help
status: passed
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: passed
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: passed
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: passed
- task: lint_license_headers
status: passed
---
Coverage Report
The above coverage report was generated for the changes in this PR. |
|
|
||
| # flattenFromBy | ||
|
|
||
| > Flatten an [ndarray][@stdlib/ndarray/ctor] from a specified dimension while applying a callback function to each element. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| > Flatten an [ndarray][@stdlib/ndarray/ctor] from a specified dimension while applying a callback function to each element. | |
| > Flatten an [ndarray][@stdlib/ndarray/ctor] according to a callback function starting from a specified dimension. |
Applies here and throughout this PR.
kgryte
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this is looking good. Initial comment only concerns updating the descriptions to better align with what we already use in flatten-from and flatten-by.
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:
Resolves stdlib-js/metr-issue-tracker#115.
Description
This pull request:
ndarray/flatten-from-byRelated Issues
This pull request has the following related issues:
ndarray/flatten-from-bymetr-issue-tracker#115Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
Utilized AI for most of the things in the checklist above.
@stdlib-js/reviewers