feat(spend): cache-first and 5m TTL for dashboard - #3107
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1f4bbb2cc7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if !force, | ||
| let lastAt = self.lastSpendDashboardTokenFetchAt[provider.instanceID], | ||
| let lastScope = self.lastSpendDashboardTokenFetchScope[provider.instanceID], | ||
| lastScope == costScopeSignature, | ||
| self.spendDashboardTokenSnapshotPublicationForCurrentConfig(for: provider) != nil, |
There was a problem hiding this comment.
This TTL cannot fire through production code: the sole caller in SpendDashboardSource.makeRequest always passes force: true, while .refreshMissing invokes that caller only when no current publication exists—even though this condition requires one. Consequently, the new five-minute guard cannot suppress any dashboard token scan; the caller needs to preserve the build mode's forced/non-forced semantics or perform the TTL decision before the missing-publication predicate.
Useful? React with 👍 / 👎.
clawsweeper
Bot
added
P2
|
Codex review: needs real behavior proof before merge. Reviewed August 26, 2026, 11:30 AM ET / 15:30 UTC. ClawSweeper reviewWhat this changesThis PR makes the Spend dashboard load retained Codex and OpenCodex usage caches first, refresh stale data after five minutes, and migrate compatible local cache schemas. Merge readiness⛔ Blocked until real behavior proof is added - 3 items remain Keep open: current main does not contain the cache-first/TTL behavior, and the latest head resolves the prior requested-log fallback issue without a remaining source-level finding. Real after-fix Spend dashboard proof is still required before merge. Priority: P2 Review scores
Verification
Live VerificationCommand: Result: FAIL (failed) — execution before step 1 Assertions:
How this fits togetherThe Spend dashboard combines provider token snapshots with locally cached Codex and OpenCodex usage to show cost and activity. This PR changes the cache-read, migration, and refresh decisions before that data reaches the dashboard pane. flowchart LR
A[Usage logs] --> B[Local usage caches]
B --> C[Cache migration and windowed reads]
C --> D[Dashboard loader]
E[Provider snapshots] --> D
D --> F[Spend dashboard model]
F --> G[Preferences pane]
Before merge
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Provide a redacted fresh-bundle dashboard demonstration that shows retained data appearing first and a subsequent refresh after the TTL without losing migrated history. Do we have a high-confidence way to reproduce the issue? Not applicable: this PR introduces cache-first and TTL behavior rather than reporting a standalone current-main bug. Is this the best way to solve the issue? Yes for the source-level implementation: the requested-log-path check preserves same-path retained-cache recovery while rejecting cross-home reuse; real dashboard evidence remains necessary to validate the complete user flow. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against cf79d1310493. LabelsLabel justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (30 earlier review cycles; latest 8 shown)
|
|
CI failure is a real compile error:
|
4582171 to
d3596a6
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d3596a6a84
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let shouldPrimeCachedCodex: Bool = self.cachedLoader != nil | ||
| && !Set(Self.codexOwnershipByID(configuration.codexAccountIdentities).keys) | ||
| .isSubset(of: Set(self.loadedInputs.map(\.id))) | ||
| && (phase == .ordinary || self.loadedInputs.isEmpty) |
There was a problem hiding this comment.
LoadPhase does not conform to Equatable, and its reconciling(ForcedOutcome) payload prevents synthesized conformance, so phase == .ordinary produces a “binary operator '==' cannot be applied” compiler error and blocks every build. Preserve the prior if case .ordinary = phase pattern or introduce an explicit case-checking property; the repository-required test run would have caught this before handoff.
AGENTS.md reference: AGENTS.md:L23-L24
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ac856d5c36
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let identity = "\(logURL.path)|\(size)|\(mtime)" | ||
|
|
||
| if let cached = self.readCachedEntries(identity: identity), !cached.isEmpty { | ||
| if let cached = self.readCachedEntries(identity: identity, since: since) { |
There was a problem hiding this comment.
When usage.jsonl has changed since the previous read—as it normally does whenever a new request is appended—the identity check here misses and loadEntries reparses, deduplicates, sorts, and returns the entire lifetime log without applying since. Consequently, the new window only limits SQLite cache-hit reads, while active users continue hitting the unbounded latency and memory path this change is meant to avoid; apply the cutoff in the parser/miss path as well, while retaining the full cache if needed.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 73bc2a1a34
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| for baseline in providerBaselines where mode.shouldRefresh( | ||
| hasPublication: baseline.publication != nil, | ||
| isDashboardTokenStale: store.spendDashboardTokenFetchIsStale(for: baseline.provider)) |
There was a problem hiding this comment.
When the pane is reopened after five minutes without a configuration change, SpendDashboardPane.onAppear calls update(configuration:), but the equality guard in SpendDashboardController.update returns before building a request, so the stale predicate added here is never evaluated. Fresh evidence in the current tree is that the patch now correctly passes the non-forced mode to the loader, while the unchanged controller guard still prevents that path from running on an ordinary reopen. The cached snapshot can therefore remain beyond the advertised TTL until a configuration/date change or manual refresh triggers another load.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Apply the cutoff before parsing cache misses
When usage.jsonl changes, this cache-miss path still parses the entire lifetime file, materializes every entry in unique, sorts the full collection, and rewrites all entries before the since filter runs. Thus active logs remain subject to unbounded peak memory and refresh latency even though the returned array is windowed. Fresh evidence in the current tree is that the follow-up only filters deduped after these full-history operations; pass the cutoff into parsing or otherwise avoid materializing old entries on the report path.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b577455ac9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let rowsByPath = mode == .scanReady | ||
| ? Dictionary(grouping: snapshot.usageRows, by: \.path) | ||
| : [:] |
There was a problem hiding this comment.
When cached Codex usage contains reasoning tokens or usage preceding a historical pricing cutoff, .aggregateReport discards the persisted rows and reconstructs them from day/model aggregates. Those synthesized rows omit both reasoning and timestampUnixMs, while buildCodexReportFromCache derives displayed reasoning totals and date-sensitive pricing from those fields. Consequently, the cache-first snapshot can report zero reasoning and price historical usage at current rates; retain the required metadata in the aggregate representation or decode the rows needed for an equivalent report.
Useful? React with 👍 / 👎.
| guard self.tokenSnapshotPublicationForCurrentProviderConfig(for: provider) != nil, | ||
| let legacyLast = self.lastTokenFetchAt[provider.instanceID] | ||
| else { return true } | ||
| return Date().timeIntervalSince(legacyLast) >= 5 * 60 |
There was a problem hiding this comment.
When the regular token pipeline has just published its default 30-day snapshot before the first dashboard open, this branch treats it as fresh solely from its timestamp even though the dashboard requests scanDays == 365. capturedTokenPublication then falls back to that legacy snapshot and skips the independent dashboard fetch, so the dashboard's 365-day/All view is populated with only 30 days of history until another refresh is triggered. Reuse legacy freshness only when its history coverage and scope satisfy the dashboard request.
Useful? React with 👍 / 👎.
clawsweeper
Bot
added
the
merge-risk: 🚨 compatibility
b577455 to
d0c3479
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d0c347973b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| || snapshot.metadata.timeZoneIdentifier == calendar.timeZone.identifier | ||
| else { return CostUsageCache() } | ||
| return Self.cache(from: snapshot) | ||
| return Self.cache(from: snapshot, mode: mode) |
There was a problem hiding this comment.
When the Codex cache approaches its 25,000-row or 256 MB budget, .aggregateReport still calls readSnapshot(), whose implementation reads and copies every usage_rows.payload blob and every token snapshot before cache(from:mode:) discards those arrays. As a result, the new dashboard path avoids JSON decoding but still incurs full-cache SQLite I/O and memory allocation on first paint; use a mode-specific snapshot reader that does not query these tables.
Useful? React with 👍 / 👎.
d0c3479 to
d8c5ae9
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d8c5ae9269
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if let cached = self.readCachedEntries(identity: identity, since: since) { | ||
| return cached |
There was a problem hiding this comment.
When the matching SQLite cache cannot be read completely—for example, sqlite3_step returns SQLITE_BUSY/SQLITE_ERROR, or every cached payload fails decoding—readCachedEntries currently returns an empty array, and this newly unconditional cache-hit branch accepts it instead of reparsing the valid JSONL source. The OpenCodex source is then published as confirmed empty and remains so until the log identity changes; distinguish a successfully completed zero-row query from read/decoding failures and return nil for the latter.
Useful? React with 👍 / 👎.
77b21f3 to
9cb04e2
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9cb04e241b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| WHERE timestamp >= ? | ||
| ORDER BY timestamp, request_id |
There was a problem hiding this comment.
When an existing OpenCodex cache contains a large lifetime history, this query still performs a full scan of entries and sorts the matches because the schema only indexes the request_id primary key, not timestamp. Thus every dashboard cache hit remains proportional to the entire cache rather than the 365-day window this change is intended to load; add a (timestamp, request_id) index and ensure existing schema-version-1 databases receive it.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 328a4360d6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let snapshot = self.readSnapshot(skipRowTables: mode == .aggregateReport) | ||
| guard snapshot.metadata.timeZoneIdentifier == nil | ||
| || snapshot.metadata.timeZoneIdentifier == calendar.timeZone.identifier | ||
| else { return CostUsageCache() } | ||
| return Self.cache(from: snapshot) | ||
| return Self.cache(from: snapshot, mode: mode) |
There was a problem hiding this comment.
When cache-first hydration must rebuild a report from aggregates rather than use an exact previous report, the synthesized token-bearing rows have no eventIndex, so codexRowCostBreakdown marks them unstable and rowCostIsTrusted is always false. Standard usage then falls back to aggregate pricing that excludes the newly separated reasoning tokens, while priority evidence disables that fallback entirely and produces a nil cost. Fresh evidence is that the current patch now synthesizes reasoning/timestamp metadata, but this aggregate-mode path still discards its row-level pricing, so cached spend remains lower or unavailable until the live scan finishes.
Useful? React with 👍 / 👎.
| Self.bindAggregateValues(aggregate, to: insert, startingAt: 4) | ||
| Self.bind(aggregate.earliestTimestampUnixMs, to: insert, at: 20) |
There was a problem hiding this comment.
For every persisted file aggregate, this statement has only 18 parameters: the 14 values bound starting at index 4 end at 17, making earliest_timestamp_ms parameter 18 rather than 20. SQLite therefore returns SQLITE_RANGE for this ignored bind and inserts NULL for the timestamp; the global aggregate insert repeats the same off-by-two error at index 19 instead of 17. Fresh evidence is that the patch added timestamp persistence to preserve date-sensitive pricing, but cached historical rows still lose that metadata and resolve without their original pricing date.
Useful? React with 👍 / 👎.
328a436 to
e4466e0
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 63e8df340e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| $0 + ($1.inputTokens ?? 0) + ($1.cacheReadTokens ?? 0) | ||
| + max(0, ($1.outputTokens ?? 0) - ($1.reasoningTokens ?? 0)) |
There was a problem hiding this comment.
For this fixture, stored.data already exposes output exclusive of reasoning because the changed scanner stores deltaOutput - deltaReasoningTokens; expectedUnits was likewise updated to count exclusive output. Subtracting reasoningTokens here a second time therefore undercounts every reasoning-bearing entry and makes the final storedUnits == expectedUnits assertion fail. The repository-required full test run would expose this regression.
AGENTS.md reference: AGENTS.md:L23-L23
Useful? React with 👍 / 👎.
| if self.spendDashboardTokenSnapshotPublicationForCurrentConfig(for: provider) != nil { | ||
| return false |
There was a problem hiding this comment.
After the first successful or confirmed-empty dashboard scan, this branch treats the current publication as fresh whenever lastSpendDashboardTokenFetchAt is absent, but this change also removes the only production assignment to that dictionary and no success path replaces it. With an unchanged provider scope, the five-minute comparison is consequently never reached and ordinary pane reopens reuse the publication indefinitely; record the completion time when publishing a successful or empty result while leaving failures timestamp-free.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4381ec51ae
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let rowsByPath = mode == .scanReady | ||
| ? Dictionary(grouping: snapshot.usageRows, by: \.path) | ||
| : [:] |
There was a problem hiding this comment.
When a cached day/model contains multiple standard requests, this aggregate-only path discards their individual rows and later synthesizes one row containing the entire daily input. Long-context pricing is request-scoped, so two 150k-token requests below a 200k threshold become one 300k-token row; because that synthetic row has no eventIndex, makeCodexBilledDayEntry rejects its row cost and codexAggregateCostUSD returns nil once the aggregate exceeds the threshold. The cache-first dashboard therefore loses an otherwise computable cost until the live scan finishes; retain per-request threshold evidence or a trustworthy persisted computed cost.
Useful? React with 👍 / 👎.
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5fdf6d7d05
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // back at the output rate (see `codexResolvedCostUSD`), keeping USD unchanged while | ||
| // making token buckets additive. | ||
| let deltaReasoningTokens = deltaReasoning ?? 0 | ||
| let outputExcludingReasoning = max(0, deltaOutput - deltaReasoningTokens) |
There was a problem hiding this comment.
When reasoning exceeds the non-reasoning output remainder, this representation change truncates reasoning in project/model analytics. For example, an event with 100 output and 60 reasoning now stores (output: 40, reasoning: 60); CodexLocalProjectUsageIndexer forwards those values to CodexModelsUsageFragment, whose initializer in CodexModelsAnalyticsModels.swift clamps reasoning to outputTokens, reducing it to 40. Update that downstream invariant for the new exclusive-output representation so analytics retain the actual reasoning count.
Useful? React with 👍 / 👎.
clawsweeper
Bot
added
the
rating: 🦪 silver shellfish
|
@clawsweeper re-review b8315b5 |
|
🦞🧹 I asked ClawSweeper to review this item again. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: da069eb4ae
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| private static func pricingSegments( | ||
| from rows: [CostUsageScanner.CodexUsageRow]) -> [StoredCodexPricingSegment]? | ||
| { | ||
| guard !rows.isEmpty else { return nil } |
There was a problem hiding this comment.
When a current scanned session has codexRows = []—for example, a valid rollout with no token-count events—persistFile records hasRows: true, but this guard serializes pricingSegments as nil. aggregateReportNeedsLegacyRows then misclassifies the file as a base-schema-3 cache and reruns readSnapshot(skipRowTables: false), decoding every usage-row and token-snapshot payload in the database on each cache-first dashboard load. Fresh evidence after the earlier row-table skip fix is this nil/empty collision; persist [] for current empty row sets or otherwise distinguish them from legacy metadata.
Useful? React with 👍 / 👎.
da069eb to
cccccb5
Compare
|
Clean rebuild evidence for current head
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cccccb5a61
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let requestEvidence = value.allRowsHaveKnownCost | ||
| || value.requests.count < 2 | ||
| || value.input <= CostUsagePricing.codexPricingEvidenceThresholdTokens | ||
| ? [] | ||
| : value.requests |
There was a problem hiding this comment.
When a persisted row has unpricedTokens > 0 but its segment contains one request or no more than 200k input tokens, this stores an empty requestEvidence array; the synthesized segment row then has no unpricedTokens, so codexIncompletePricingEvidenceGroups no longer suppresses aggregate pricing. For partially unpriced rows whose model is otherwise resolvable, the cache-first dashboard can therefore display a complete estimated cost until the live scan replaces it; preserve the flag at segment level or retain request evidence whenever any row is explicitly unpriced.
Useful? React with 👍 / 👎.
clawsweeper
Bot
added
rating: 🧂 unranked krab
6faf0be to
25e9187
Compare
|
Clean rebuild follow-up for current head
@clawsweeper re-review |
|
🦞👀 Re-review progress:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 25e9187bac
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| static let compatibleLegacyBaseParserHashes: Set<String> = compatiblePredecessorParserHashes.union([ | ||
| "3d0a976f7698a916", // Latest base-3 producer before the aggregate timestamp migration. | ||
| "dd19ffa2dcfa8d47", // Base-3 producer immediately before the spend-cache branch. | ||
| "1f23f8ea684bf2f2", // Earlier base-3 producer with the same aggregate table shape. | ||
| ]) |
There was a problem hiding this comment.
When upgrading a cache written by this commit's direct parent, the database contains base schema 3 with parser hash c6c46a376ba16304 (the parent value in CodexParserHash.generated.swift), but that hash is absent from this compatibility set. canMigrateLegacyBase therefore rejects the database as incompatible, and rebuildDatabase deletes it instead of running the new in-place migration, so existing users lose the warmed cache and must rescan their full Codex history before the cache-first dashboard is restored. Add the direct predecessor hash and cover that exact upgrade path rather than only synthetic older hashes.
Useful? React with 👍 / 👎.
|
Final-head re-review request for
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
clawsweeper
Bot
added
rating: 🦪 silver shellfish
25e9187 to
1c94b36
Compare
|
P1 fix for current head
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
|
Pushed fix When the source log is temporarily unavailable, Validation on the pushed head:
This is isolated-fixture evidence only; no provider credentials or Keychain reads were used. Real dashboard interaction proof is still pending. @clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 10d078b64b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // A retained cache is still useful while the append-only source log is | ||
| // temporarily unavailable (for example during rotation or a sync gap). | ||
| // Read it before treating the missing log as an empty source. | ||
| return self.readCachedState(since: since)?.entries ?? [] |
There was a problem hiding this comment.
When OPENCODEX_HOME changes between launches and the new home's usage.jsonl is missing, this fallback reads the process-wide OpenCodex cache without checking that parseCursor.path matches logURL.path. The dashboard will therefore attribute and display usage retained from the previous OpenCodex home instead of reporting the newly selected source as unavailable; only reuse the cache when its cursor belongs to the requested log path.
Useful? React with 👍 / 👎.
clawsweeper
Bot
added
rating: 🧂 unranked krab
10d078b to
fd4dc88
Compare
|
Pushed fix Changes:
Validation on the pushed head:
This is isolated-fixture evidence only; no provider credentials or Keychain reads were used. Real dashboard interaction proof remains pending. @clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
2 participants
Summary
Clean rebuild of PR #3107 on current
upstream/main(26132179a), kept to the spend dashboard cache-first/5-minute TTL feature.SakanaUsageFetcherTests.swiftchange from the earlier polluted branch.Review fixes
pricingSegments: []) while keeping legacy missing metadata distinguishable.unpricedTokensevidence during aggregate hydration.c6c46a376ba16304) to the compatible migration hashes so existing caches migrate in place.cached.parseCursor.path == logURL.path), returning empty when switching to an unavailable different home.Validation
swift test --filter 'CodexBarTests.OpenCodexUsageStore(IncrementalTests|WindowTests)'— 30 tests passed.make check— passed; SwiftFormat clean and SwiftLint found 0 violations in 1,999 files.fd4dc8853(fix(opencodex): bind retained cache fallback to requested log path).