Conversation
…end adds NoType when is part of a CallStmt
sergisiso
temporarily deployed
to
integration
GitHub Actions
Inactive
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3343 +/- ##
=======================================
Coverage 99.95% 99.95%
=======================================
Files 386 386
Lines 54187 54215 +28
=======================================
+ Hits 54165 54193 +28
Misses 22 22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…atatype_information
…atatype_information
sergisiso
temporarily deployed
to
integration
GitHub Actions
Inactive
Collaborator
Author
|
@arporter @LonelyCat124 This is ready for review |
arporter
requested changes
Feb 25, 2026
Member
arporter
left a comment
arporter
left a comment
There was a problem hiding this comment.
Looks good Sergi - it's nice to see the improvements to the typing making their way 'upwards'. Just some tidying/clarification and I'm a bit puzzled by a couple of the tests.
…ansformation and tests
Collaborator
Author
|
@arporter This is ready for another review |
sergisiso
temporarily deployed
to
integration
GitHub Actions
Inactive
arporter
approved these changes
Mar 2, 2026
Member
arporter
left a comment
arporter
left a comment
There was a problem hiding this comment.
Thanks Sergi, all looks good now.
I see the ITs were green last time.
The link-check failures seem to be github having a wobble.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I started this branch to tackle the WHERE with reduction intrinsics, but as in my previous PRs I think this should be solved first in ArrayAssignment2Loop and then integrate it to the WHERE.
The reductions that end up with a scalar can are already be done because we know that that term does not need additional indexing after applying ArrayAssignment2Loop. However the call.datatype was quite limited. It worked for Intrinsics but not generic calls (even when we had a RoutineSymbol with information). And RoutineSymbols defaulted to NoType, even when that was not necessarely the case (I think UnresolvedType is a better default and use the frontend type, e.g. is a CallStmt, to give it the NoType).
I have made the changes needed to fix the above and I feel its already enough for a PR, the WHEREs will come in a follow up.