Skip to content

(Closes #3347) Fixes losing directives and comments on select case block.#3349

Merged
arporter merged 8 commits intomasterfrom
3347_lost_directives_switch
Feb 26, 2026
Merged

(Closes #3347) Fixes losing directives and comments on select case block.#3349
arporter merged 8 commits intomasterfrom
3347_lost_directives_switch

Conversation

@LonelyCat124
Copy link
Copy Markdown
Collaborator

No description provided.

@LonelyCat124 LonelyCat124 requested review from arporter and sergisiso and removed request for sergisiso February 24, 2026 12:24
@LonelyCat124 LonelyCat124 changed the title (Closes #3347) Fixes directives on select case. (Closes #3347) Fixes losing directives and comments on select case block. Feb 24, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.95%. Comparing base (b703387) to head (8bd0575).
⚠️ Report is 9 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3349   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files         384      384           
  Lines       54225    54271   +46     
=======================================
+ Hits        54203    54249   +46     
  Misses         22       22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LonelyCat124
Copy link
Copy Markdown
Collaborator Author

@arporter @sergisiso This is ready for a look.

Copy link
Copy Markdown
Member

@arporter arporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this so quickly Aidan. I think it's OK but it would help to see what the generated code looks like in the test too. I'll run the ITs next time around.

@LonelyCat124
Copy link
Copy Markdown
Collaborator Author

@arporter ready for another look. Also added where test in here but it just worked correctly so no code changes to support it.

Copy link
Copy Markdown
Member

@arporter arporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks Aidan.
Just a bit of tidying to do.
I've fired off the ITs just now.

@LonelyCat124
Copy link
Copy Markdown
Collaborator Author

@arporter I think I fixed all this, ready for another look.

@LonelyCat124
Copy link
Copy Markdown
Collaborator Author

LonelyCat124 commented Feb 25, 2026

Martin has some other cases so I'll try to check that too before we merge this.
Edit: that was covered by #3350

Copy link
Copy Markdown
Member

@arporter arporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Aidan, pretty much done now. There's just one test that I think should be split into two and then this is good to go.

@LonelyCat124
Copy link
Copy Markdown
Collaborator Author

@arporter Fixed, added the missing test declaration back in, sorry for that.

@schreiberx
Copy link
Copy Markdown
Collaborator

Thanks a lot for this update! It fixes my problem.

Copy link
Copy Markdown
Member

@arporter arporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Aidan, all good now. ITs were all green.
@schreiberx is happy and I will proceed to merge :-)

@arporter arporter merged commit a7b7d27 into master Feb 26, 2026
15 checks passed
@arporter arporter deleted the 3347_lost_directives_switch branch February 26, 2026 12:19
@schreiberx
Copy link
Copy Markdown
Collaborator

Thanks a lot :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants