(Closes #3347) Fixes losing directives and comments on select case block.#3349
(Closes #3347) Fixes losing directives and comments on select case block.#3349
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3349 +/- ##
=======================================
Coverage 99.95% 99.95%
=======================================
Files 384 384
Lines 54225 54271 +46
=======================================
+ Hits 54203 54249 +46
Misses 22 22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@arporter @sergisiso This is ready for a look. |
arporter
left a comment
There was a problem hiding this comment.
Thanks for tackling this so quickly Aidan. I think it's OK but it would help to see what the generated code looks like in the test too. I'll run the ITs next time around.
…e into 3347_lost_directives_switch
|
@arporter ready for another look. Also added where test in here but it just worked correctly so no code changes to support it. |
arporter
left a comment
There was a problem hiding this comment.
Looking good, thanks Aidan.
Just a bit of tidying to do.
I've fired off the ITs just now.
|
@arporter I think I fixed all this, ready for another look. |
|
|
arporter
left a comment
There was a problem hiding this comment.
Thanks Aidan, pretty much done now. There's just one test that I think should be split into two and then this is good to go.
|
@arporter Fixed, added the missing test declaration back in, sorry for that. |
|
Thanks a lot for this update! It fixes my problem. |
arporter
left a comment
There was a problem hiding this comment.
Thanks Aidan, all good now. ITs were all green.
@schreiberx is happy and I will proceed to merge :-)
|
Thanks a lot :-) |
No description provided.