test: add fee timer blocking test coverage by xyephy · Pull Request #70 · stratum-mining/sv2-tp

xyephy · 2025-11-27T18:14:45Z

Add test coverage for the fee-based rate limiting timer that was marked with a TODO in template_provider.cpp. The timer blocks fee-based template updates until fee_check_interval seconds have passed (-sv2interval flag).

The test uses is_test=false to exercise the actual timer logic that is normally bypassed in tests. It verifies:

Fee increases are blocked when the timer hasn't fired
Fee increases are allowed after the timer fires

Also adds a TPTester constructor overload to accept custom options, allowing tests to configure is_test and fee_check_interval independently.

Closes #67

Sjors · 2025-11-28T15:54:47Z

+    TPTester tester{opts};
+
+    tester.handshake();
+    tester.handshake();


I don't know why the original has two handshake calls, that might be a bug.

It would be good to reduce the amount of duplicated test code, that also makes it more clear how each test case is different.

let me do a clean up and have a much clearer approach

d54d4b7 is better, but the code between coinbase_output_constraint_bytes and BOOST_REQUIRE_EQUAL(initial_bytes, expected_pair_bytes) is still duplicated. Can you extract that into one or more helpers?

yes, I have addressed it in ef1a258 . Thank you.

Sjors · 2026-02-10T14:09:39Z

marked with a TODO in template_provider.cpp

Does that mean the TODO can go away?

xyephy · 2026-02-11T20:48:05Z

marked with a TODO in template_provider.cpp

Does that mean the TODO can go away?

yes

Sjors · 2026-02-16T15:54:01Z

-        }
-
-        BOOST_REQUIRE_MESSAGE(seen_prev_hash, std::string("Missing SetNewPrevHash during ") + context);
-        BOOST_REQUIRE_MESSAGE(seen_new_template, std::string("Missing NewTemplate during ") + context);


Looks like you've lost part of this ~~entire~~ test now?

I've restored the lost bit

They still seem missing as of 05585cd.

that's a good catch, let me reset and redo. Thank you

Sjors · 2026-02-16T15:55:33Z

It's (slightly) easier to review the deduplication commit if you do it first.

Sjors · 2026-02-17T09:26:06Z

            // -sv2interval=N requires that we don't send fee updates until at least
            // N seconds have gone by. So we first call waitNext() without a fee
            // threshold, and then on the next while iteration we set it.
-            // TODO: add test coverage


05585cd: nit, this in the wrong commit now (don't worry about it)

let me do a better cleanup, thank you.

Sjors · 2026-04-15T15:35:09Z

The first commit still seems to be doing a lot more than "deduplicate". It's difficult to review that way. Try having commit per change (or make fewer changes, if possible).

xyephy · 2026-04-15T19:35:32Z

The first commit still seems to be doing a lot more than "deduplicate". It's difficult to review that way. Try having commit per change (or make fewer changes, if possible).

Thanks for pointing that out, I've broken them down to 4 commits to make it easier to review.

Sjors · 2026-04-17T12:29:49Z

    tester.handshake();

-    // After the handshake the client must send a SetupConnection message to the
-    // Template Provider.


bd127df: I think this comment was fine?

Sjors · 2026-04-17T12:34:25Z

    tester.m_mining_control->Shutdown();
 }

+// Test fee-based rate limiting timer (-sv2interval flag).


d1a5e03 nit: I merged #90, so this needs a rename

Sjors · 2026-04-17T12:36:57Z

Code review ACK aa53b10

But needs a trivial rebase after #90.

The client_tests test case called tester.handshake() twice in succession. The second call overwrites all state from the first, making the first a no-op. Remove it.

Extract SendSetupConnection(), SendCoinbaseOutputConstraints() and ReceiveTemplatePair() into TPTester so the setup sequence is not repeated inline. Move the SV2 message size constants into the TPTester header for reuse.

Add a TPTester constructor overload that accepts custom options, allowing tests to set is_test=false and a short fee_check_interval. The new fee_timer_blocking_test verifies that fee-based template updates are blocked until the -sv2interval timer fires. Closes stratum-mining#67

A new block should always produce a template immediately, even when the -sv2interval fee timer has not yet elapsed. This completes the three test scenarios requested in stratum-mining#67.

xyephy · 2026-04-17T16:53:48Z

Code review ACK aa53b10

But needs a trivial rebase after #90.

I've rebased.

xyephy marked this pull request as draft November 27, 2025 18:16

Sjors reviewed Nov 28, 2025

View reviewed changes

xyephy force-pushed the 2025/11/fee-timer-test branch from fffb55b to d54d4b7 Compare November 28, 2025 20:22

xyephy marked this pull request as ready for review December 9, 2025 08:11

xyephy force-pushed the 2025/11/fee-timer-test branch from d54d4b7 to ef1a258 Compare February 11, 2026 20:56

Sjors reviewed Feb 16, 2026

View reviewed changes

xyephy force-pushed the 2025/11/fee-timer-test branch from ef1a258 to cfe50cd Compare February 17, 2026 09:17

Sjors reviewed Feb 17, 2026

View reviewed changes

xyephy force-pushed the 2025/11/fee-timer-test branch from cfe50cd to 1d3013e Compare March 31, 2026 14:41

xyephy force-pushed the 2025/11/fee-timer-test branch from 1d3013e to aa53b10 Compare April 15, 2026 19:21

Sjors reviewed Apr 17, 2026

View reviewed changes

Sjors mentioned this pull request Apr 17, 2026

fuzz: add raw deserialization targets for SV2 messages #81

Merged

xyephy added 4 commits April 17, 2026 19:48

test: remove duplicate handshake call

ed20273

The client_tests test case called tester.handshake() twice in succession. The second call overwrites all state from the first, making the first a no-op. Remove it.

test: deduplicate SV2 template provider test helpers

f29f70a

Extract SendSetupConnection(), SendCoinbaseOutputConstraints() and ReceiveTemplatePair() into TPTester so the setup sequence is not repeated inline. Move the SV2 message size constants into the TPTester header for reuse.

test: verify new tips bypass fee rate-limiting timer

5225964

A new block should always produce a template immediately, even when the -sv2interval fee timer has not yet elapsed. This completes the three test scenarios requested in stratum-mining#67.

xyephy force-pushed the 2025/11/fee-timer-test branch from aa53b10 to 5225964 Compare April 17, 2026 16:53

Sjors merged commit 5225964 into stratum-mining:master Apr 20, 2026
20 checks passed

Conversation

xyephy commented Nov 27, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Sjors commented Feb 10, 2026

Uh oh!

xyephy commented Feb 11, 2026

Uh oh!

Sjors Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Sjors commented Feb 16, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Sjors commented Apr 15, 2026

Uh oh!

xyephy commented Apr 15, 2026

Uh oh!

Sjors Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Sjors commented Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xyephy commented Apr 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Sjors Feb 16, 2026 •

edited

Loading

Sjors Apr 17, 2026 •

edited

Loading

Sjors commented Apr 17, 2026 •

edited

Loading