mac: init CEF before running NSApplication loop#1614
Merged
sandboxcoder merged 1 commit intoobs_merge_31.1.2from Jan 6, 2026
Merged
mac: init CEF before running NSApplication loop#1614sandboxcoder merged 1 commit intoobs_merge_31.1.2from
sandboxcoder merged 1 commit intoobs_merge_31.1.2from
Conversation
* Apparently CEF 6533 (obs31.1) is a bit more strict how it is initialized. Now CefInitialize() will be invoked before NSApplication is instantiated.
sandboxcoder
force-pushed
the
rno/mac-init-cef
branch
from
e512c9a to
1701228
Compare
sandboxcoder
changed the title
aleksandr-voitenko
approved these changes
Jan 5, 2026
summeroff
pushed a commit
that referenced
this pull request
Mar 11, 2026
* Apparently CEF 6533 (obs31.1) is a bit more strict how it is initialized. Now CefInitialize() will be invoked before NSApplication is instantiated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding a state machine to track application state (Idle, initAPI, initCEF, Stop) which is helpful to ensure
CefInitializeis called after api has been initialized. This way, obs-browser can be properly initialized in the main thread.Motivation and Context
Solves issue where Google Chromium would fail to initialize. Most notably, it solves this crash:
How Has This Been Tested?
Attaching a test case that creates a browser source. Also verified in SLD.
Types of changes
Checklist: