Skip to content

chore: Updated Vortice.Vulkan package to the latest version 2.1.2 -> 3.0.3#2991

Merged
Eideren merged 3 commits intostride3d:masterfrom
Feralnex:vortice-vulkan-package-update-3_0_3
Jan 11, 2026
Merged

chore: Updated Vortice.Vulkan package to the latest version 2.1.2 -> 3.0.3#2991
Eideren merged 3 commits intostride3d:masterfrom
Feralnex:vortice-vulkan-package-update-3_0_3

Conversation

@Feralnex
Copy link
Copy Markdown
Contributor

@Feralnex Feralnex commented Dec 2, 2025

PR Details

Updated Vortice.Vulkan package to the latest version (2.1.2 -> 3.0.3)

Related Issue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@xen2
Copy link
Copy Markdown
Member

xen2 commented Dec 3, 2025

Quick question, will there be any changes in the C# code (due to binding changes)?
If yes, let me know, and depending how big the changes are, it might be better to do the changes in https://github.com/xen2/stride/tree/vulkan_wip

@Feralnex
Copy link
Copy Markdown
Contributor Author

Feralnex commented Dec 3, 2025

Quick question, will there be any changes in the C# code (due to binding changes)? If yes, let me know, and depending how big the changes are, it might be better to do the changes in https://github.com/xen2/stride/tree/vulkan_wip

Yes, there will be some changes to the code, but as far as I noticed it's all about extracting InstanceApi and DeviceApi instead of invoking functions directly from the library. Also there were some changes to the way the core functions work (instead of single call we always get VkResult as a return type and extracting the specific result is done by another call). Let me know if I should branch off from Your fork then.

@amerkoleci
Copy link
Copy Markdown
Contributor

Hey,
As always, ping me if you need any information or doubts :)

Thanks

@Feralnex Feralnex marked this pull request as ready for review December 17, 2025 18:32
@Feralnex Feralnex changed the title [WIP] Updated Vortice.Vulkan package to the latest version 2.1.2 -> 3.0.3 Updated Vortice.Vulkan package to the latest version 2.1.2 -> 3.0.3 Dec 17, 2025
@Eideren Eideren requested a review from xen2 December 17, 2025 18:49
@Kryptos-FR
Copy link
Copy Markdown
Member

Kryptos-FR commented Jan 9, 2026

I think the branch should be rebased on top of master while keeping only the commit(s) that updates the package version, and any related modified code.

Currently there seems to be a lot of unrelated changes because of some incorrect merging, possibly cause by the merge issue we had a few days ago, where the master branch was on the wrong "side" of the merge for PR #1715.

Alternatively, reset the branch to before the last merge, fetch the latest master and redo the merge.

Edit: seems fixed now.

@Feralnex Feralnex closed this Jan 10, 2026
@Feralnex Feralnex force-pushed the vortice-vulkan-package-update-3_0_3 branch from fc07c7d to 33eba55 Compare January 10, 2026 12:58
@Feralnex Feralnex reopened this Jan 10, 2026
@Eideren Eideren merged commit cba4e2a into stride3d:master Jan 11, 2026
10 of 14 checks passed
@Eideren
Copy link
Copy Markdown
Collaborator

Eideren commented Jan 11, 2026

Thanks !

@Eideren Eideren changed the title Updated Vortice.Vulkan package to the latest version 2.1.2 -> 3.0.3 chore: Updated Vortice.Vulkan package to the latest version 2.1.2 -> 3.0.3 Jan 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants