Skip to content

Add missing CupertinoNavigationBar params for Flutter 3.27 #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DFelten wants to merge 2 commits into
base: master
Choose a base branch
from
+10 −0
Open

Add missing CupertinoNavigationBar params for Flutter 3.27 #468

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7b430b
Add missing CupertinoNavigationBar params for Flutter 3.27
DFelten Dec 19, 2024
a9090ad
Add params to non hero variant
DFelten Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions lib/src/platform_app_bar.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,8 @@ class CupertinoNavigationBarData extends _BaseData {
this.transitionBetweenRoutes,
this.brightness,
this.heroTag,
this.automaticBackgroundVisibility,
this.enableBackgroundFilterBlur,
this.noMaterialParent = false,
});

Expand All @@ -127,6 +129,8 @@ class CupertinoNavigationBarData extends _BaseData {
final bool? transitionBetweenRoutes;
final Object? heroTag;
final bool? automaticallyImplyMiddle;
final bool? automaticBackgroundVisibility;
final bool? enableBackgroundFilterBlur;
final String? previousPageTitle;
final EdgeInsetsDirectional? padding;
final Brightness? brightness;
Expand Down Expand Up @@ -241,6 +245,9 @@ class PlatformAppBar
transitionBetweenRoutes: data?.transitionBetweenRoutes ?? true,
brightness: data?.brightness,
heroTag: heroTag,
automaticBackgroundVisibility:
data?.automaticBackgroundVisibility ?? true,
enableBackgroundFilterBlur: data?.enableBackgroundFilterBlur ?? true,
);
}

Expand All @@ -262,6 +269,9 @@ class PlatformAppBar
.withWidgetFinder<CupertinoNavigationBar>(),
transitionBetweenRoutes: data?.transitionBetweenRoutes ?? true,
brightness: data?.brightness,
automaticBackgroundVisibility:
data?.automaticBackgroundVisibility ?? true,
enableBackgroundFilterBlur: data?.enableBackgroundFilterBlur ?? true,
//heroTag: , used above
);
}
Expand Down