chore: Use constants for all errors - #2676
Open
TobCar wants to merge 1 commit into
Open
Conversation
TobCar
force-pushed
the
refactor/oauth-error-code-constants
branch
from
August 4, 2026 16:37
0875c8b to
1fcb2f0
Compare
Author
|
ptal @cstockton |
TobCar
changed the title
TobCar
force-pushed
the
refactor/oauth-error-code-constants
branch
from
August 4, 2026 19:27
1fcb2f0 to
522721c
Compare
TobCar
force-pushed
the
refactor/oauth-error-code-constants
branch
from
August 5, 2026 06:44
522721c to
6390ecd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Inspired by #2660 this PR introduces constants for all errors.
What is the current behavior?
The repo was using strings for each error code.
While updating these, I actually discovered
token_oidc.gohad an error code that violates RFC 6749:invalid requestis not allowed to have a space.What is the new behavior?
The apierrors package containts a constant with every error code emitted. I also fixed
invalid request->invalid_request.