chore(stack): sync service version manifest and fix sync workflow - #6103
chore(stack): sync service version manifest and fix sync workflow#6103mandarini wants to merge 2 commits into
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c3a96ce5d8
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| FROM axllent/mailpit:v1.30.2 AS mailpit | ||
| FROM postgrest/postgrest:v14.16 AS postgrest | ||
| FROM supabase/postgres-meta:v0.96.6 AS pgmeta | ||
| FROM supabase/postgres-meta:v0.96.8 AS pgmeta |
There was a problem hiding this comment.
This bump only changes the embedded Go Dockerfile manifest, but the TypeScript stack defaults are generated from the same manifest and still have pgmeta: "0.96.6" in packages/stack/src/versions.ts:63; resolvePgmetaConfig uses that default when no override is provided. For users starting the TS/@supabase/stack local runtime without --service-version pgmeta=..., the CLI will continue pulling v0.96.6, so the dependency bump does not take effect there. Please include the packages/stack version sync output with this change.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
To use Codex here, create an environment for this repo.
Supabase CLI previewnpx --yes https://pkg.pr.new/supabase/cli/supabase@e6563819f7bea1163c8d74e98f89c43ae7545236Preview package for commit |
pgmeta, realtime, storage, and analytics defaults in ServiceCatalog.ts were still pinned to the versions from before dependabot's docker-minor group bump (#6107), since the sync-stack-service-versions workflow no-ops on the stale versions.ts path fixed in the next commit.
The version-refactor split DEFAULT_VERSIONS out of versions.ts into ServiceCatalog.ts, but this workflow still diffed and staged versions.ts, so it silently no-op'd instead of committing the synced ServiceCatalog.ts after dependabot Dockerfile bumps.
a026982 to
e656381
Compare
mandarini
changed the title
|
closed because dependabot updated |
2 participants
What changed
The original pg-meta Dockerfile bump in this PR was superseded by dependabot's
docker-minorgroup bump (#6107), which landed ondevelopfirst and already bumpedpostgres-meta,realtime,storage-api, andlogflareinapps/cli-go/pkg/config/templates/Dockerfile.That surfaced the real issue flagged in review:
packages/stack/src/ServiceCatalog.ts'sDEFAULT_VERSIONS(used by the TS/@supabase/stacklocal runtime) had drifted from the Dockerfile for all 4 of those services, because.github/workflows/sync-stack-service-versions.ymlstill diffed/staged the pre-refactorpackages/stack/src/versions.tspath instead ofServiceCatalog.ts(whereDEFAULT_VERSIONSnow lives), so it silently no-op'd instead of committing the sync after dependabot's PR.This PR:
pnpm sync:versionsto bringServiceCatalog.tsback in sync with the Dockerfile (pgmeta, realtime, storage, analytics).ServiceCatalog.tsso future dependabot Dockerfile bumps sync correctly again.