feat: cleanup ebs snapshots from testinfra ami's#2098
Open
jfreeland wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds cleanup logic to the Testinfra AMI build workflow to remove AMI artifacts created during the run, aiming to prevent lingering AWS resources (and associated costs) after the workflow completes.
Changes:
- Fetch EBS snapshot IDs associated with the “stage 2” AMIs created by the workflow.
- Deregister stage 2 AMIs and attempt to delete their backing EBS snapshots.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jfreeland
changed the title
samrose
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Delete the EBS snapshots backing testing AMI's that are built from the testinfra workflow. I think we're not deleting the snapshots when we're done and this has to be done separately in AWS.