Skip to content

fix(pg_upgrade): retry nix-store -r to avoid hangs on stalled S3 fetches #2220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jfreeland merged 4 commits into from
Jun 16, 2026
+21 −2
Merged

fix(pg_upgrade): retry nix-store -r to avoid hangs on stalled S3 fetches #2220

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
77151ce
fix(pg_upgrade): retry nix-store -r to avoid hangs on stalled S3 fetches
jfreeland Jun 15, 2026
22d31be
fix: cleaner log, comment
jfreeland Jun 16, 2026
7f09041
Merge branch 'develop' into fix/pg-upgrade-initiate
jfreeland Jun 16, 2026
6422c43
chore: valid copilot feedback
jfreeland Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions ansible/files/admin_api_scripts/pg_upgrade_scripts/initiate.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,8 +348,27 @@ EXTRA_NIX_CONF

echo "Store path: $STORE_PATH"

# Realize from binary cache (no nix evaluation needed!)
nix-store -r "$STORE_PATH"
# Realize the closure from the binary cache.
#
# nix-store -r can stall indefinitely on a dropped S3 connection without
# erroring out (its own download timeout doesn't reliably fire), so guard each
# attempt with a timeout and retry. Each path downloads atomically: already-
# registered paths are skipped on retry but an in-flight NAR restarts from
# 0%. Failing as a normal command (not exit 1) lets the ERR trap run cleanup
# and record "failed" instead of hanging.
nix_store_ok="false"
for attempt in 1 2 3; do
if timeout -k 10s 120s nix-store -r "$STORE_PATH"; then
nix_store_ok="true"
Comment thread
jfreeland marked this conversation as resolved.
break
fi
if [ "$attempt" -lt 3 ]; then
echo "WARNING: nix-store -r attempt ${attempt}/3 for $STORE_PATH failed or stalled (>=120s + up to 10s kill grace); retrying"
Comment thread
jfreeland marked this conversation as resolved.
else
echo "ERROR: nix-store -r failed after 3 attempts for $STORE_PATH"
fi
done
[ "$nix_store_ok" = "true" ]

PG_UPGRADE_BIN_DIR="$STORE_PATH"
PGSHARENEW="$PG_UPGRADE_BIN_DIR/share/postgresql"
Expand Down
Loading