Skip to content

feat(tools): 7-tool parity and description refresh - #1432

Open
Dhravya wants to merge 5 commits into
chore/ci-python-sdk-testsfrom
feat/tools-seven-tool-parity
Open

feat(tools): 7-tool parity and description refresh#1432
Dhravya wants to merge 5 commits into
chore/ci-python-sdk-testsfrom
feat/tools-seven-tool-parity

Conversation

@Dhravya

@Dhravya Dhravya commented Aug 8, 2026

Copy link
Copy Markdown
Member

Summary

  • Refresh canonical tool descriptions in tools-shared.ts
  • Align OpenAI and AI SDK tool bindings with 7-tool surface
  • Export TOOL_DESCRIPTIONS / PARAMETER_DESCRIPTIONS from package index

Stacked on #1431

Test plan

  • bun run test:unit in packages/tools

Made with Cursor

Update shared tool descriptions (proactive search, documentAdd guidance),
export TOOL_DESCRIPTIONS from package index, and align OpenAI/AI SDK tool
schemas with memoryForget and document operations.

Co-authored-by: Cursor <cursoragent@cursor.com>
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Aug 8, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
supermemory-mcp 7153801 Aug 22 2026, 06:47 AM

@claude

claude Bot commented Aug 8, 2026

Copy link
Copy Markdown

Claude finished @ved015's task in 1m 57s —— View job


Code Review Complete

  • Loading review tools
  • Fetching PR diff and existing review comments
  • Analyzing changes for bugs, security issues, and logic errors
  • Submitting review

Summary: Reviewed the 7-tool parity and SDK v3→v4 migration changes. The implementation is solid with improved container-tag scoping for document deletions.

One issue to address: restore the missing test assertion expect(stored).not.toContain("line3") (already flagged by Graphite) before merging.

Score: 9/10

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Aug 8, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
supermemory-app 7153801 Commit Preview URL

Branch Preview URL
Aug 22 2026, 06:49 AM

Comment on lines +165 to +180
it.each(["$&", "$'", "$`", "$$"])(
"stores %s literally instead of expanding it as a replacement pattern",
async (dollarSequence) => {
const result = await tool.handleCommand({
command: "str_replace",
path: FILE_PATH,
old_str: "line3",
new_str: `price is ${dollarSequence} today`,
})

expect(result.success).toBe(true)
expect(addMock).toHaveBeenCalledTimes(1)
const stored = addMock.mock.calls[0]?.[0]?.content as string
expect(stored).toContain(`price is ${dollarSequence} today`)
},
)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test regression: the assertion expect(stored).not.toContain("line3") was removed during reformatting. The test now only verifies the new string was added but doesn't verify the old string was actually replaced. This weakens test coverage and won't catch if str_replace fails to remove the old content.

expect(stored).toContain(`price is ${dollarSequence} today`)
expect(stored).not.toContain("line3") // Add this back
Suggested change
it.each(["$&", "$'", "$`", "$$"])(
"stores %s literally instead of expanding it as a replacement pattern",
async (dollarSequence) => {
const result = await tool.handleCommand({
command: "str_replace",
path: FILE_PATH,
old_str: "line3",
new_str: `price is ${dollarSequence} today`,
})
expect(result.success).toBe(true)
expect(addMock).toHaveBeenCalledTimes(1)
const stored = addMock.mock.calls[0]?.[0]?.content as string
expect(stored).toContain(`price is ${dollarSequence} today`)
},
)
it.each(["$&", "$'", "$`", "$$"])(
"stores %s literally instead of expanding it as a replacement pattern",
async (dollarSequence) => {
const result = await tool.handleCommand({
command: "str_replace",
path: FILE_PATH,
old_str: "line3",
new_str: `price is ${dollarSequence} today`,
})
expect(result.success).toBe(true)
expect(addMock).toHaveBeenCalledTimes(1)
const stored = addMock.mock.calls[0]?.[0]?.content as string
expect(stored).toContain(`price is ${dollarSequence} today`)
expect(stored).not.toContain("line3") // Add this back
},
)

Spotted by Graphite

Fix in Graphite


Is this helpful? React 👍 or 👎 to let us know.

Dhravya commented Aug 8, 2026

Copy link
Copy Markdown
Member Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label Main to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Comment thread packages/tools/src/ai-sdk.ts
Comment thread packages/tools/src/claude-memory.ts Outdated
Comment thread packages/tools/src/tools-shared.ts Outdated
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@socket-security

socket-security Bot commented Aug 18, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addednpm/​supermemory@​4.25.46610010095100

View full report

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview: This PR upgrades the supermemory SDK from v3 to v4, aligns 7 tool bindings with the new API surface, and refreshes tool descriptions for clarity.

Issues found: The missing test assertion (expect(stored).not.toContain("line3")) was already flagged by Graphite — this is a real test coverage regression that should be restored. The other Graphite comments (unused includeFullDocs, implicit any type, Biome formatting) are linter/style issues.

The core implementation changes are solid:

  • The deleteDocumentByIdentifier logic properly resolves IDs within scoped container tags before deletion, preventing cross-scope data access
  • The container tag validation correctly rejects empty strings
  • The getFileDocument refactor to use document listing + GET instead of search is more reliable for exact-match file operations
  • Error handling for ambiguous document identifiers is appropriate

Score: 9/10 — Clean logic, improved scoping safety. Restore the dropped test assertion before merging.

- Replace `as any` with typed assertion in claude-memory.ts
- Apply Biome formatting fixes

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants