Replace numpy.amax and numpy.amin with numpy.max and numpy.min throughout#1119
Replace numpy.amax and numpy.amin with numpy.max and numpy.min throughout#1119edbennett wants to merge 2 commits intoswcarpentry:mainfrom
Conversation
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/swcarpentry/python-novice-inflammation/compare/md-outputs..md-outputs-PR-1119 The following changes were observed in the rendered markdown documents: What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2026-04-28 19:52:07 +0000 |
Per the discussion in #1117, this PR instead replaces all instances of
numpy.amaxandnumpy.aminwithnumpy.maxandnumpy.minrespectively. This matches the current recommended and most common convention for computing the maximum and minimum with Numpy, and avoids a source of cognitive load.Since I had already recreated the illustration for #1117, this also redraws the previously PNG figure as an SVG.