Fix compilation on nightly-main Swift, which has new optional type inference#900
Merged
simonjbeaumont merged 2 commits intoswift-server:mainfrom Mar 24, 2026
Merged
Conversation
fabianfett
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Swift nightly-main has regressed how existential types interact with generic parameter inference through optionals.
startRequestSpan<T>(tracer: T?)is called withself.anyTracer, typed(any Sendable)?. The compiler previously inferredT = any Sendable, but nightly-main now rejects this, producing:Modification
Replace the generic parameter
<T>with an explicit(any Sendable)?parameter type. The generic existed solely to erase theTracerprotocol from the signature so that non-availability-guarded code could call the method. Accepting(any Sendable)?directly serves the same purpose.There is no performance impact: the call site already passes an existential-typed value, so
Twas always inferred asany Sendableand never specialized to a concrete type. The force-cast to(any Tracer)?inside the function is unchanged.Result
Fixes compilation on Swift nightly-main. No behavioural change.
Related
swiftlang/swift#88058