Skip to content

[lldb] Flip swift-use-context-free-po default value to true #11997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kastiglione wants to merge 1 commit into
base: swift/release/6.3
Choose a base branch
from
Open

[lldb] Flip swift-use-context-free-po default value to true #11997

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lldb/source/Target/Target.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4768,8 +4768,8 @@ bool TargetProperties::GetSwiftUseContextFreePrintObject() const {
if (exp_values)
return exp_values
->GetPropertyAtIndexAs<bool>(ePropertySwiftUseContextFreePrintObject)
.value_or(false);
return false;
.value_or(true);
return true;
}

void TargetProperties::SetUseDIL(ExecutionContext *exe_ctx, bool b) {
Expand Down
2 changes: 1 addition & 1 deletion lldb/source/Target/TargetProperties.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ let Definition = "target_experimental" in {
DefaultTrue,
Desc<"Enables caching of task pointers inside the swift tasks plugin">;
def SwiftUseContextFreePrintObject: Property<"swift-use-context-free-po", "Boolean">,
DefaultFalse,
DefaultTrue,
Desc<"If true, use the context-free po implementation for Swift.">;
def UseDIL : Property<"use-DIL", "Boolean">,
Global, DefaultTrue,
Expand Down
2 changes: 0 additions & 2 deletions lldb/test/API/lang/swift/expression/error_reporting/TestSwiftExpressionErrorReporting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,6 @@ def test_missing_type(self):
target, process, thread, bkpt = lldbutil.run_to_source_breakpoint(
self, 'break here', lldb.SBFileSpec('main.swift'))

self.runCmd("settings set target.experimental.swift-use-context-free-po true")

options = lldb.SBExpressionOptions()
value = self.frame().EvaluateExpression("strct", options)
def check(value):
Expand Down
1 change: 0 additions & 1 deletion .../API/lang/swift/po/pointer_and_mangled_typename/TestSwiftPrintObjectPointerAndTypeName.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ class TestCase(TestBase):

def setUp(self):
TestBase.setUp(self)
self.runCmd("settings set target.experimental.swift-use-context-free-po true")

self.log = self.getBuildArtifact("expr.log")
self.runCmd(f"log enable lldb expr -f {self.log}")
Expand Down