WIP: Add BorrowingSequence above Sequence #86066
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far this runs into the issue that conditionally-conforming Sequence types (like Range<Int>) don't implicitly conform to BorrowingSequence.
natecook1000
changed the title
Contributor
|
Returning self from this default impl of makeBorrowingInterator() is consuming, so it requires a copyable type (like Span).
This disables the SwiftOnone code that triggers errors like: Cannot pre-specialize $sSMsSKRzrlE14_insertionSort6within2byySny5IndexSlQzG_Sb7ElementSTQz_AHtKXEtKF and also disables the diagnostics when those prespecialized symbols can no longer be found.
Member
Author
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
BorrowingSequenceand makesSequenceextend the new protocol.Issues still to tackle:
Sequenceprotocol when its declaration would require the availability-constrainedBorrowingSequence– availability checking currently offSequencetypes (likeRange<Int>) don't implicitly conform toBorrowingSequenceSwiftOnone.swiftspecialization code and the bit of the compiler that verifies the existence of those prespecialized symbols