Skip to content

Conversation

@tembleking
Copy link
Member

Summary

  • Replace Dockerfile and .dockerignore with pure Nix image builds (dockerTools.buildLayeredImage + pkgsCross)
  • Build linux/amd64 and linux/arm64 images via nix build
  • Publish workflow pushes images by digest (via skopeo) and assembles multi-arch manifests with docker buildx imagetools create
  • Test workflow runs both arch builds in a matrix; functional test and scan run on amd64
  • Add skopeo to dev shell and use nix develop --command bash {0} as default shell in CI jobs

Test plan

  • Test Image Build workflow passes for both matrix entries (amd64 + arm64)
  • Verify nix build .#sysdig-mcp-server-image-amd64 produces a loadable image locally
  • Verify nix build .#sysdig-mcp-server-image-aarch64 completes successfully

Replace Dockerfile with Nix-based image builds using dockerTools.buildLayeredImage
and pkgsCross for cross-compilation. Images are pushed by digest via skopeo and
assembled into multi-arch manifests with docker buildx imagetools.
@tembleking tembleking requested a review from a team as a code owner February 6, 2026 14:34
Copilot AI review requested due to automatic review settings February 6, 2026 14:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates Docker image builds from a traditional Dockerfile to a pure Nix-based approach using dockerTools.buildLayeredImage, enabling native multi-architecture support for both linux/amd64 and linux/arm64.

Changes:

  • Replaced Dockerfile and .dockerignore with Nix-based image definitions (docker.nix, docker-base-amd64.nix, docker-base-aarch64.nix)
  • Updated CI workflows to build and test both architectures using a matrix strategy, with digest-based pushing and multi-arch manifest creation
  • Added development tooling (nix-prefetch-docker, skopeo) and a justfile recipe to update base images

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
justfile Adds recipe to fetch and update base image metadata for both architectures
flake.nix Defines multi-arch image packages using pkgsCross and adds required dev tools
docker.nix Implements Nix-based Docker image builder with architecture-specific base image selection
docker-base-amd64.nix Defines metadata for the amd64 base image
docker-base-aarch64.nix Defines metadata for the aarch64 base image
Dockerfile Removed traditional Dockerfile in favor of Nix approach
.dockerignore Removed as it's no longer needed with Nix builds
.github/workflows/test_image.yaml Updated to build and test both architectures in a matrix with Nix
.github/workflows/publish.yaml Refactored to build arch-specific images, push by digest, and create multi-arch manifests

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings February 6, 2026 15:09
@tembleking tembleking force-pushed the feat/multi-arch-docker-nix branch from 3393fcd to c6a46cf Compare February 6, 2026 15:09
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings February 9, 2026 09:57
@tembleking tembleking force-pushed the feat/multi-arch-docker-nix branch from cca88dc to c6a46cf Compare February 9, 2026 09:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated 6 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings February 9, 2026 10:27
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 14 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tembleking tembleking force-pushed the feat/multi-arch-docker-nix branch from 04d4e38 to a2d05ad Compare February 9, 2026 10:33
Copilot AI review requested due to automatic review settings February 9, 2026 10:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 14 out of 15 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings February 9, 2026 14:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 14 out of 15 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings February 9, 2026 14:30
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 14 out of 15 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tembleking tembleking merged commit 458c6c5 into main Feb 9, 2026
5 checks passed
@tembleking tembleking deleted the feat/multi-arch-docker-nix branch February 9, 2026 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants