Skip to content

Use a locator to wait for bracket marks to clear #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jserv merged 1 commit into from
Oct 10, 2026
Merged

Use a locator to wait for bracket marks to clear #268

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions tests/browser/editor-pipeline.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,9 +377,12 @@ test("caret and focus changes reuse ranges until code or language changes", asyn
editor.focus();
});
await page.keyboard.press("ControlOrMeta+A");
await page.waitForFunction(
() => document.querySelectorAll(".matching-bracket").length === 0,
);
// Selecting all clears the bracket marks in a queued paint. Count the
// replacement only after that paint, whatever frame the keypress reached.
await page
.locator(".matching-bracket")
.first()
.waitFor({ state: "detached" });
await page.evaluate(() => {
window.overlayPaints = 0;
});
Expand Down