Potential fix for code scanning alert no. 30: Hard-coded cryptographic value#205
Closed
StefanSteiner wants to merge 1 commit into
Closed
Potential fix for code scanning alert no. 30: Hard-coded cryptographic value#205StefanSteiner wants to merge 1 commit into
StefanSteiner wants to merge 1 commit into
Conversation
…c value Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/tableau/hyper-api-rust/security/code-scanning/30
Use a non-sensitive test variable for the password instead of an inline hard-coded password literal at the
.auth(...)call site.Best fix here (without changing functionality): define a local test password variable in
test_sync_pool_config_builder_and_defaultsand pass that variable to.auth("u", test_password). This preserves test behavior while removing the direct hard-coded password literal that CodeQL flags.Edit only
hyperdb-api/src/pool.rs, in thetest_sync_pool_config_builder_and_defaultstest around line 1228:let test_password = "test-password";.auth("u", "p")with.auth("u", test_password)No new imports, methods, or dependencies are required.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.