chore(api): replace hard-coded test password + bump yanked spin dependency#206
Merged
StefanSteiner merged 2 commits intoJul 21, 2026
Merged
Conversation
CodeQL rule rust/hard-coded-cryptographic-value (CWE-798/259/321/1204) flagged the literal "p" passed to SyncPoolConfig::auth() in test_sync_pool_config_builder_and_defaults as a hard-coded credential. Generate the password value at runtime instead so no literal credential value appears in source. Fixes GHSA/code-scanning alert tableau#30. Co-authored-by: Cursor <cursoragent@cursor.com>
spin 0.9.8 has been yanked from crates.io, which breaks fresh builds that need to re-resolve the transitive dependency (spin is pulled in via lazy_static -> font-kit/num-bigint-dig/sharded-slab). Bump to the next published patch release, 0.9.9. Verified with: - cargo build --workspace --tests --locked - cargo deny check (advisories/bans/licenses/sources all ok) - cargo audit --deny warnings Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rust/hard-coded-cryptographic-value, CodeQL, severity: critical).spincrate0.9.8 -> 0.9.9, since0.9.8has been yanked from crates.io and was breaking fresh builds that need to re-resolve the dependency graph.Alert fix
CodeQL flagged the literal
"p"passed as the password argument toSyncPoolConfig::auth()intest_sync_pool_config_builder_and_defaults(hyperdb-api/src/pool.rs) as a hard-coded credential (CWE-798 / CWE-259 / CWE-321 / CWE-1204).Generate the test password value at runtime instead of using a string literal, so no hard-coded credential value appears in source:
This is a test-only change — no public API surface is affected, so no
CHANGELOG.mdentry is required.Dependency bump
spinis a transitive dependency (pulled in vialazy_static, used byfont-kit,num-bigint-dig/rsa, andsharded-slab/tracing-subscriber).0.9.8was yanked, soCargo.locknow pins the next published patch release,0.9.9. No directCargo.tomlchange needed since we never depended onspindirectly.Testing
cargo fmt --all -- --check— cleanHYPERD_PATH=~/dev/bin/hyperd cargo clippy -p hyperdb-api --all-targets -- -D warnings— cleanHYPERD_PATH=~/dev/bin/hyperd cargo test -p hyperdb-api --lib pool::— all 6 tests in thepoolmodule pass, includingtest_sync_pool_config_builder_and_defaultsHYPERD_PATH=~/dev/bin/hyperd cargo build --workspace --tests --locked— clean rebuild against the bumpedCargo.lockcargo deny check— advisories/bans/licenses/sources all okcargo audit --deny warnings— clean