security: add environment gate to production PyPI publish job#1830
Merged
Conversation
Adds `environment: pypi` to the publish-pypi job, wiring it to the GitHub Environment configured with required reviewers. Without this, any repo write holder could push a tag or invoke workflow_dispatch and publish to production PyPI with no human checkpoint. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jacalata
force-pushed
the
jac/publish-pypi-environment-gate
branch
from
July 23, 2026 23:12
f426c4e to
13af29d
Compare
bcantoni
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
environment: pypito thepublish-pypijob in.github/workflows/publish-pypi.yml.Without this, any repo write holder can push a tag matching
v*.*.*, triggerworkflow_dispatch, or publish a release and the production PyPI publish runs immediately with no human checkpoint. ThepypiGitHub Environment is already configured on this repo with required reviewers (tableau/devplat),can_admins_bypass: false, andprevent_self_review: true— this change wires the job to it.No logic changes — one line added.
🤖 Generated with Claude Code