Repository navigation
Keep the Changed changelog section for changes that users may have to act on - #20728
Conversation
[Low impact] The documentation changes appear safe to merge. Reviews (3) · Last reviewed commit: "Move the canonicalization entry of [Unre..." · Reviewed by Greptile |
A canonicalization improvement is not a new feature for users, like the canonicalization entries of 4.3.4 and 4.3.5 in Fixed. Update the guide in CONTRIBUTING.md to match.
|
No actionable comments were generated in the recent review. WalkthroughThe changelog instructions now link to contributor guidance for selecting a section. The guidance adds classification criteria and examples, including that performance improvements belong under Merge Risk:
|
This PR keeps
### Changedin the changelog for changes that users may have to act on, and documents which section to use.[Unreleased]had a### Changedsection with two performance entries (#20680 and #20688). A performance improvement is not a change that users have to act on, and the repo already lists them under### Fixed(e.g. #20694, #20678 and #20663).Changes
CHANGELOG.md: remove the### Changedsection of[Unreleased]. Combine the two entries into one entry in### Fixed, because Use the incremental build whenfromis set #20688 only extends Only optimize and print new utilities on rebuilds #20680 to the other integrations. The entry goes in the merge order of Only optimize and print new utilities on rebuilds #20680.CHANGELOG.md: move the canonicalization entry of Replace CSS escapes that are not needed during canonicalization #20697 from### Addedto### Fixed, in merge order, and drop the empty### Addedheading. A canonicalization improvement is not a new feature for users, and the canonicalization entries of 4.3.4 and 4.3.5 are in### Fixedtoo..github/CONTRIBUTING.md: add a guide on which section to pick. The examples for### Changedcome from earlier releases: changes to the CSS of existing utilities, renamed or replaced utilities (also when the upgrade tool migrates them), theme defaults, APIs, stricter parsing, source detection defaults, and supported versions..changelog/README.md: link to that guide.This PR edits
CHANGELOG.mddirectly instead of adding a fragment, because it fixes entries that the "Compile changelog" workflow already compiled. Released sections stay as they are. The PR changes only docs, so it needs no changelog entry of its own.Test plan
pnpm changelog checkpasses.pnpm --silent changelogshows[Unreleased]with only### Fixed.pnpm prettier --checkpasses for the three files.