Field aliases now use hashes, not linear scan#141
Open
bigbes wants to merge 4 commits intotarantool:masterfrom
Open
Field aliases now use hashes, not linear scan#141bigbes wants to merge 4 commits intotarantool:masterfrom
bigbes wants to merge 4 commits intotarantool:masterfrom
Conversation
….1+) * Update test-run.py and lib/tarantool_server.py to support python 3 * Update tests accordingly to new version of PHPUnit * Added initialization of standart class properties to 'Tarantool'
Totktonada
reviewed
Dec 12, 2018
Contributor
Totktonada
left a comment
Totktonada
left a comment
There was a problem hiding this comment.
Looks good in general. Added minor comments.
Blocked until #140 will be merged.
| } | ||
| #define MH_DEFINE_CMPFUNC(NAME, TYPE) \ | ||
| int mh_##NAME##cmp_eq(const TYPE **lval, const TYPE **rval, \ | ||
| void *arg) { \ |
| } \ | ||
| \ | ||
| int mh_##NAME##cmp_key_eq(const struct schema_key *key, \ | ||
| const TYPE **val, void *arg) { \ |
Contributor
There was a problem hiding this comment.
Two whitespaces before tabs.
| if (strncmp(val->field_name, field_name, field_name_len) == 0) | ||
| return val->field_number; | ||
| } | ||
| return -1; |
Contributor
There was a problem hiding this comment.
It seems it was the singleton use of the schema_list/schema_list_len, so these fields can be removed now from struct schema_space_value?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#24