Meta: Update Yet Phrase Checking with ESMeta v0.7.3#3738
Closed
Meta: Update Yet Phrase Checking with ESMeta v0.7.3#3738
Conversation
Member
|
Duplicate of #3739 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the version of ESMeta to v0.7.3 and supports a more precise yet-phrase checking to resolve the problem mentioned in #3733.
Now, the yet-phrase checker detects diff pairs of removed and added lines in the
spec.htmlfile and filters out pairs whose removed lines already contain yet-phrases or yet-types. Then, it shows alert messages only for the yet-phrases or yet-types in the added lines of the remaining pairs.For example, among 147 commits from dd4300d to 8febdac, the following 13 commits have at least one yet-phrase or yet-type alert:
However, since only maximum 10 alerts are allowed to be shown in the
Files changedtab, we also show a summary of the detected yet-phrases and yet-types in the Actions log ($GITHUB_STEP_SUMMARY).For example, the commit 3dfa316 has 11 yet-phrase alerts and 10 yet-type alerts, but only 10 alerts are shown in the
Files changedtab (see here). The full list of alerts is available in the summary of the Actions log (see here).