Skip to content

Conversation

@zkochan
Copy link
Member

@zkochan zkochan commented Dec 16, 2025

Proposed Changes

@zkochan zkochan marked this pull request as ready for review December 18, 2025 14:21
Copilot AI review requested due to automatic review settings December 18, 2025 14:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds support for updating dependencies in env.jsonc files when running the bit update command. Previously, bit update only updated dependencies in workspace.jsonc and component configurations, but did not handle dependencies defined in environment component's env.jsonc files.

Key changes:

  • Introduces a new jsonc-utils component for parsing and modifying JSONC files while preserving formatting
  • Extends dependency resolution to include dependencies from env.jsonc files
  • Implements logic to update env.jsonc files with new dependency versions, including special handling for peerDependencies' supportedRange

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 12 comments.

Show a summary per file
File Description
scopes/toolbox/json/jsonc-utils/jsonc-utils.ts New utility functions for parsing, stringifying, and updating JSONC files while preserving formatting (indentation, newlines, comments)
scopes/toolbox/json/jsonc-utils/index.ts Exports for the new jsonc-utils component
scopes/toolbox/json/jsonc-utils/jsonc-utils.docs.mdx Comprehensive documentation for the jsonc-utils utility with examples and use cases
scopes/dependencies/dependency-resolver/get-all-policy-pkgs.ts Adds 'env-jsonc' as a new CurrentPkgSource type to track where dependencies are defined
scopes/dependencies/dependency-resolver/dependency-resolver.main.runtime.ts Implements getEnvJsoncPolicyPkgs() to extract dependencies from env.jsonc files and integrates them into the dependency resolution flow
scopes/workspace/install/install.main.runtime.ts Implements updateEnvJsoncPolicies() to write updated dependency versions back to env.jsonc files and integrates it into the update workflow
scopes/workspace/install/pick-outdated-pkgs.ts Updates unique name generation and adds context rendering for env-jsonc dependencies in the interactive selection UI
scopes/workspace/install/pick-outdated-pkgs.spec.ts Updates test expectations to match new unique naming scheme with index suffixes
e2e/harmony/dependencies/env-jsonc-policies.e2e.ts Adds end-to-end tests verifying that bit update correctly updates env.jsonc files and handles supportedRange for peerDependencies
.bitmap Registers the new json/jsonc-utils component in the workspace

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings January 5, 2026 13:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 6 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings January 5, 2026 14:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings January 5, 2026 15:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 9 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings January 6, 2026 13:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings January 6, 2026 15:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings January 6, 2026 16:30
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 6 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@zkochan zkochan requested a review from GiladShoham January 6, 2026 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant