chore: migrate more aspect-docs components to mdx-env 3.0.3#10510
chore: migrate more aspect-docs components to mdx-env 3.0.3#10510GiladShoham wants to merge 9 commits into
Conversation
PR Summary by QodoMigrate remaining aspect-docs components to mdx-env 3.0.3
AI Description
Diagram
High-Level Assessment
Files changed (3)
|
Code Review by Qodo
1. Caret range enables drift
|
| "rootDir": "scopes/webpack/config-mutator", | ||
| "config": { | ||
| "teambit.node/node@2.0.3": {} | ||
| } |
There was a problem hiding this comment.
1. Versioned core env config 🐞 Bug ☼ Reliability
.bitmap config sets the env for two components to teambit.node/node@2.0.3, but core envs/aspects are identified by exact unversioned ids (e.g. teambit.node/node). This can cause Bit to treat the Node env as a non-core aspect id during extension/aspect loading for these components, leading to incorrect resolution/loading behavior.
Agent Prompt
## Issue description
Two `.bitmap` component entries configure the Node env as `teambit.node/node@2.0.3`. `teambit.node/node` is a core aspect/env whose core detection and core filtering are based on exact unversioned string ids, so the versioned key bypasses core treatment.
## Issue Context
- `teambit.node/node` is registered as a core aspect.
- Core aspect/env checks are exact string matches.
- During extensions loading, the resolved id string (including version) is passed into `loadAspects()`, which filters core aspects by exact id list, so `...@2.0.3` is not removed.
- Workspace code explicitly documents that core envs must be configured **without** a version.
## Fix Focus Areas
- .bitmap[1097-1106]
- .bitmap[1177-1186]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
| "@teambit/component-id": "^1.2.4", | ||
| "@teambit/component-version": "^1.0.4", | ||
| "@teambit/component.content.component-overview": "1.96.6", | ||
| "@teambit/component.content.component-overview": "^1.96.10", |
There was a problem hiding this comment.
1. Caret range enables drift 🐞 Bug ⚙ Maintainability
workspace.jsonc changes @teambit/component.content.component-overview from an exact version to ^1.96.10, which allows future installs/lockfile regenerations to silently pull newer compatible versions of this docs/content package. This makes future doc/UI behavior changes harder to reproduce and debug compared to the surrounding exact-pinned 1.96.x content deps.
Agent Prompt
### Issue description
`workspace.jsonc` now specifies `@teambit/component.content.component-overview` with a caret range (`^1.96.10`). Unlike exact version pins, this permits dependency drift when the lockfile is regenerated or when installs occur without a frozen lockfile, potentially changing rendered docs/UI content without an explicit PR.
### Issue Context
Nearby `*.content.*` dependencies are pinned to exact versions (e.g. `@teambit/bit.content.what-is-bit`, `@teambit/compilation.content.compiler-overview`). The lock currently resolves `@teambit/component.content.component-overview@1.96.10`, but the range allows future upgrades.
### Fix Focus Areas
- workspace.jsonc[167-176]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
|
Code review by qodo was updated up to the latest commit 5bd16b9 |
…x-env-migration-cleanup # Conflicts: # pnpm-lock.yaml
|
Code review by qodo was updated up to the latest commit f2a7d74 |
…teambit/bit into chore/mdx-env-migration-cleanup
|
Code review by qodo was updated up to the latest commit 65e87d8 |
Bumps several aspect-docs/content components to their latest versions and explicitly pins
teambit.mdx/mdx-env@3.0.3on 21 aspect-docs components (babel, builder, compiler, component, compositions, dependency-resolver, envs, generator, html, logger, etc.), cleaning up remaining places still using the old MDX 1.x env in favor of v3.