Skip to content

feat: collapse task queues to default by TaskQueueResolver #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xepozz wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: collapse task queues to default by TaskQueueResolver #749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/Acceptance/App/RuntimeBuilder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ private static function iterateClasses(string $featuresDir, string $ns): iterabl
$feature = new Feature(
testClass: $class,
testNamespace: $namespace,
taskQueue: $namespace,
taskQueue: TaskQueueResolver::resolve($class, $namespace),
);

yield $feature => \array_filter(
Expand Down
51 changes: 51 additions & 0 deletions tests/Acceptance/App/TaskQueueResolver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
<?php

declare(strict_types=1);

namespace Temporal\Tests\Acceptance\App;

use Temporal\Tests\Acceptance\App\Attribute\Worker;

final class TaskQueueResolver
{
public const DEFAULT_TASK_QUEUE = 'default';

/**
* @var list<class-string>
*/
private const SHARED_QUEUE_EXCLUSIONS = [
\Temporal\Tests\Acceptance\Extra\Workflow\WorkflowA\WorkflowATest::class,
\Temporal\Tests\Acceptance\Extra\Workflow\WorkflowB\WorkflowBTest::class,
\Temporal\Tests\Acceptance\Harness\Activity\RetryOnError\RetryOnErrorTest::class,
\Temporal\Tests\Acceptance\Harness\Update\Self\SelfTest::class,
\Temporal\Tests\Acceptance\Harness\Update\Activities\ActivitiesTest::class,
\Temporal\Tests\Acceptance\Harness\Signal\Activities\ActivitiesTest::class,
\Temporal\Tests\Acceptance\Extra\Versioning\Classic\ClassicTest::class,
\Temporal\Tests\Acceptance\Extra\Versioning\Deployment\DeploymentTest::class,
];

/**
* @param class-string $class
* @param non-empty-string $namespace
* @return non-empty-string
*/
public static function resolve(string $class, string $namespace): string
{
if (\in_array($class, self::SHARED_QUEUE_EXCLUSIONS, true)) {
return $namespace;
}

$reflection = new \ReflectionClass($class);
foreach ($reflection->getAttributes(Worker::class) as $attribute) {
$worker = $attribute->newInstance();
if ($worker->pipelineProvider !== null
|| $worker->logger !== null
|| $worker->plugins !== null
Comment on lines +41 to +43
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot May 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve options-only worker attributes

When a feature uses #[Worker(options: ...)] without also setting a pipeline/logger/plugins, this resolver falls through to the shared default queue unless the test is manually hard-coded in SHARED_QUEUE_EXCLUSIONS. In that case worker.php reuses the already-created default worker, so WorkerFactory::createWorker() never applies that feature's custom WorkerOptions (the existing Deployment test has to be special-cased for this). Treating options like the other Worker fields here would keep future options-only features from silently running with the default worker configuration.

Useful? React with 👍 / 👎.

) {
return $namespace;
}
}

return self::DEFAULT_TASK_QUEUE;
}
}
Loading