Implement planned topic: 0015-cross-namespace-deprecation#213
Open
skill-temporal-developer-updater[bot] wants to merge 1 commit into
Open
Implement planned topic: 0015-cross-namespace-deprecation#213skill-temporal-developer-updater[bot] wants to merge 1 commit into
skill-temporal-developer-updater[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validation Report —
cross-namespace-deprecationScope:
references/go/cross-namespace-deprecation.md,references/java/cross-namespace-deprecation.md.Source of truth:
../documentation/docs/.Validator session: independent of authoring; no
AUTHORING_LOG.mdorAUTHORING_PLAN.mdexists in the skill root, and none was consulted.Go/no-go
Overall verdict: GO.
Check 1 findings
None. Every
<!-- docs/… -->citation in both files was opened and read at the cited line range. The cited text substantively supports the authored claim in every case. Notable spot-checks:docs/cloud/migrate/automated.mdx:419-422— verbatim source for thesystem.enableCrossNamespaceCommandsgating claim and the "code must be updated or removed prior to migration" requirement.docs/encyclopedia/child-workflows/child-workflows.mdx:31— the same-Namespace constraint for Child Workflows.docs/develop/go/workflows/message-passing.mdx:295— verbatim 5-argumentworkflow.SignalExternalWorkflow(ctx, "some-workflow-id", "", "your-signal-name", signal)shape, exactly as quoted by the Go file.docs/develop/java/nexus/feature-guide.mdx:86-89— verbatimtemporal operator nexus endpoint createcommand block reproduced by the Java file.docs/encyclopedia/nexus/nexus-security.mdx:33, 41— supports the Endpoint allowlist / caller-Namespace verification claim in both files.Check 2 findings
None. Tokens extracted and grepped:
workflow.ExecuteChildWorkflow,workflow.ChildWorkflowOptions,workflow.WithChildOptions,workflow.SignalExternalWorkflow— all present indocs/develop/go/workflows/.Workflow.newChildWorkflowStub,Workflow.newUntypedChildWorkflowStub,Workflow.newExternalWorkflowStub,Workflow.newUntypedExternalWorkflowStub,ChildWorkflowOptions,ExternalWorkflowStub— all present indocs/develop/java/.system.enableCrossNamespaceCommands— present indocs/cloud/migrate/automated.mdx:420-421.temporal operator nexus endpoint create,--name,--target-namespace,--target-task-queue— present indocs/develop/java/nexus/feature-guide.mdx:86-89anddocs/cli/operator.mdx.develop/go/nexus/feature-guide.mdx:23) and Java (develop/java/nexus/feature-guide.mdx:22-23).The terminological variant
RequestCancelExternal(Java file line 5) does not appear indocs/cloud/migrate/automated.mdx, which usesCancelExternal. Both refer to the same Workflow command family —RequestCancelExternalWorkflowExecutionis the canonical Event/Command name (it appears 12× acrossdocs/references/events.mdx,docs/references/commands.mdx, and elsewhere). Not a fabrication; an acceptable paraphrase.Check 3 findings
None. Universal patterns (TLS env vars,
--profile,tcld service-account,--output text/jsonl,saas-api.tmprl.cloud:7233) are absent from both files. Topic-specific patterns the validator looked for and did not find:workflow.SignalExternalWorkflow(...)with a Namespace argument — absent. The Go file quotes the documented 5-argument shape and explicitly warns against inventing a 6-arg variant (line 31).system.enableCrossNamespaceCommandsis enabled on Temporal Cloud — absent. Both files correctly state the opposite.Check 4 findings
Sample size: 10 Go citations + 12 Java citations = 22 claims.
21 matches. One claim flagged as a minor inference, not a divergence:
Workflow.newExternalWorkflowStub(...)is described as "used for sending Signals (and request-cancel) to another running Workflow Execution". The cited lines (message-passing.mdx:287, 291) document only Signal usage of this stub; "(and request-cancel)" is an inference from the broader fact thatCancelExternalis a documented Workflow command in the same family (permigrate/automated.mdx:419). The inference is consistent with Temporal's Workflow command model, but the cited line does not directly demonstrate cancel usage ofnewExternalWorkflowStub. A small "// Typed external workflow stub (same-Namespace Signal/Cancel target)" comment in the code-block annotation on line 21-25 inherits the same inference.Substantively true, but the cited source supports Signal only. Not a re-authoring trigger; mention to authoring if a follow-up pass is made.
Match rate: 21/22 = 95.5% (above 95% threshold). If the inference above is considered substantively true, 22/22 = 100%.
Check 5 findings
Not applicable — not an integration topic.
Check 6 findings
None.
Pattern 1 (workaround disclosure): clean. Both files name the gating config (
system.enableCrossNamespaceCommands) only to identify the constraint, and consistently direct the agent to Nexus. Neither file describes how to flip the config, suggest enabling it on self-hosted as an alternative to Nexus, or otherwise hand the agent a recipe for using the deprecated path. The "Don't rely onsystem.enableCrossNamespaceCommandsbehavior in code intended for Temporal Cloud; do remove or replace cross-Namespace calls before migration" line in the Go file (line 32) and equivalent in the Java file (line 61) are textbook "boundary + supported alternative" statements.Pattern 2 (in-the-weeds rationale): clean. No design-history narrative, no "behind the scenes" prose. The code blocks in the Java file (lines 18-33, 45-51) are positive grounding — they show the canonical shapes the agent should generate.
Pattern 3 (multi-sentence bullets where sentence #2 is noise): clean. Minor: the Java file's
What this affectsbullet at line 16 paraphrases the gating point already made at line 14. Not a finding — it's a summary line at the end of a list, useful for grounding.Pattern 4 (Public Preview without admonition): N/A. Nexus is GA in both SDKs per the cited feature guides; neither file claims preview status.
Statistics
Notes for downstream
Both authored files are currently untracked on the
draft/0015-cross-namespace-deprecationbranch (no commits, no diff againstmain).git log main..HEADis empty. The skill'sSKILL.mdis unchanged frommain. From a layout perspective this is fine for these per-language deprecation references — they live at the canonicalreferences/{lang}/<topic>.mdpath. Committing the new files is the only remaining gating step before merge from a scope/layout standpoint.Consider tightening Java line 14 / lines 21-25's "(and request-cancel)" / "Signal/Cancel target" parentheticals if you want every parenthetical to be backed by the immediately cited line. The broader Temporal docs support the claim, but a more direct citation (e.g. an encyclopedia page that names cancel-external as accessible via
ExternalWorkflowStub) would close the small gap.End of report.