Implement planned topic: 0014-resource-tuning#215
Open
skill-temporal-developer-updater[bot] wants to merge 4 commits into
Open
Implement planned topic: 0014-resource-tuning#215skill-temporal-developer-updater[bot] wants to merge 4 commits into
skill-temporal-developer-updater[bot] wants to merge 4 commits into
Conversation
Documents the worker-package tuner and slot-supplier APIs (NewResourceBasedTuner, NewCompositeTuner, NewResourceController, NewFixedSizeSlotSupplier, NewResourceBasedSlotSupplier) and the contrib/sysinfo provider used for both resource-based tuning input and host resource reporting in Worker heartbeats. Calls out that these APIs no longer live under contrib/resourcetuner. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Adds a single bullet to the Reference Files list in references/go/go.md so the new resource-tuning.md is discoverable from the language entry point. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Adds a one-line pointer plus the load-bearing constraint that worker.Options.Tuner and MaxConcurrentXXXTask options are mutually exclusive. Keeps the existing fixed-options snippet intact. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validation Report —
resource-tuning(Go)Branch:
draft/0014-resource-tuningSkill root:
.Reference file added:
references/go/resource-tuning.mdCross-link edits:
references/go/go.md,references/go/advanced-features.mdTopic class: core Go SDK reference (not a third-party integration — Check 5 N/A)
Go / no-go
Overall verdict: MINOR FIXES. Factual content is grounded and accurate; one minor admonition is missing.
Check 1 findings
None. All 41 inline citations across the three docs files (
worker-performance.mdx,worker-tuning-reference.mdx,worker-health.mdx) and the secondary source (sample-apps/go/features/worker_tuner/worker_tuner.go) resolve cleanly. The cited line ranges substantively support the authored claims, including the multi-source citations that combine docs lines with sample-app lines.Check 2 findings
None unexplained. One token does not appear anywhere in the documentation tree:
go.temporal.io/sdk/contrib/resourcetuner— appears only in the authored file as a negative warning ("Don't import…"). The path is being called out as a wrong-import to prevent agent fabrication; the correct paths (go.temporal.io/sdk/worker,go.temporal.io/sdk/contrib/sysinfo) are both grounded insample-apps/go/features/worker_tuner/worker_tuner.go:3-6. Acceptable as a defensive call-out, not a fabricated positive claim.All other tokens (Go API symbols, struct fields, metric names, default values, package paths) appear at least once in the docs tree.
Check 3 findings
None. Universal regression patterns (the
--profile,TEMPORAL_TLS_*_PATH,tcld service-account,--output text|jsonl,saas-api.tmprl.cloud:7233) are all absent. Topic-specific regressions are also absent:worker.ResourceBasedTunerOptionsin the resource-based tuner snippet (line 60-64) usesTargetMem/TargetCpu— correct.worker.DefaultResourceControllerOptions()in the composite tuner snippet (line 86-89) usesMemTargetPercent/CpuTargetPercent— correct.worker.NewCompositeTuneris called with the named-struct formworker.CompositeTunerOptions{...}including all four slot suppliers (line 110-115) — correct.contrib/resourcetuneror callresourcetuner.NewResourceBasedTuner(...).The wrong-pattern strings (e.g.
MemTargetPercenton tuner options) appear only inside "Don't do X" guidance and the "Common mistakes" section — these are correct negative bullets, not regressions.Check 4 findings
None. 10 / 10 sampled claims match the docs:
worker-performance.mdx:66-70worker-tuning-reference.mdx:124worker-performance.mdx:397, 402-405ResourceBasedTunerOptionsfield names)worker-performance.mdx:494-497DefaultResourceControllerOptionsfield names)worker-performance.mdx:519-522DefaultActivityResourceBasedSlotSupplierOptionsused for both activity AND local-activity)worker-performance.mdx:529, 533Tuner+MaxConcurrentXXXTaskerrors at init)worker-performance.mdx:84-86, 96-100, 224-229rampThrottlesemantics)worker-performance.mdx:464-471worker-health.mdx:402-403worker-performance.mdx:448-453Check 5 findings
N/A —
references/integrations.mdexists in the repo, but this topic is a core Go SDK reference (worker tuning, slot suppliers,SysInfoProvider), not a third-party integration. Layout audit does not apply.Check 6 findings
Pattern 4 — Public Preview without admonition.
references/go/resource-tuning.mdlines 143-162 coverworker.Options.SysInfoProvider(host resource reporting in Worker heartbeats), sourced fromdocs/cloud/worker-health.mdx:400-417. That section is a subsection of "Manage Worker Heartbeating", which is marked as Public Preview atworker-health.mdx:376-380:The authored file does not carry a
[!NOTE]admonition flagging this. Either theSysInfoProvidersection (lines 143-162) or the broader heartbeat-reporting context should carry the standard Public Preview admonition.Per the verdict rubric, Pattern 4 findings alone are MINOR FIXES, not a re-authoring trigger.
No Pattern 1 (workaround disclosure) findings — every "Don't do X" bullet is paired with the supported alternative (e.g. line 27, 129, 134 in the reference file, and the "Common mistakes" section). No Pattern 2 / 3 findings worth calling out.
Statistics
worker-performance.mdx,worker-tuning-reference.mdx,worker-health.mdx) + 1 sample app (sample-apps/go/features/worker_tuner/worker_tuner.go)contrib/resourcetuner— defensive negative call-out, acceptable)Recommended follow-up
Single-commit minor fix: add a Public Preview admonition near line 143 of
references/go/resource-tuning.mdcovering theworker.Options.SysInfoProvider/ host resource reporting content. Suggested form (matching the standard admonition phrasing used elsewhere in the skill):No re-authoring pass needed.