Implement planned topic: 0033-lambda-workers#221
Open
skill-temporal-developer-updater[bot] wants to merge 1 commit into
Open
Implement planned topic: 0033-lambda-workers#221skill-temporal-developer-updater[bot] wants to merge 1 commit into
skill-temporal-developer-updater[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skill Validation Report —
lambda-workersBranch:
draft/0033-lambda-workersScope: the three new reference files plus the three rows added to
references/integrations.md:references/go/integrations/lambda-workers.mdreferences/python/integrations/lambda-workers.mdreferences/typescript/integrations/lambda-workers.mdreferences/integrations.md(+3 catalog rows)The change is currently uncommitted in the working tree (
git log main..HEADis empty; the new files are untracked andreferences/integrations.mdis modified). Validation was performed against the working-tree state.Go/no-go
lambda.Start)TEMPORAL_TLS_CLIENT_CERT_PATH/_KEY_PATH— see below)Overall: GO — with two non-blocking notes the maintainer should look at before/after merge.
Check 1 findings — citation audit
Per-file totals (per-file subagents):
All cited docs paths exist under
../documentation/docs/. Every claim is substantively supported by its cited line range. Two marginal-but-acceptable cases in Go (opts.ClientOptionsrationale at line 63 andHOME=/tmprationale at line 175) — both citations land on lines that show the code; the rationale the skill adds is a defensible authorial annotation but is not literally stated in the docs.Check 2 findings — reverse-grep audit
Per-file totals:
lambda.Start(line 46 — "Do not calllambda.Startyourself"). This refers togithub.com/aws/aws-lambda-go/lambda.Start, the standard AWS Lambda Go SDK entrypoint. It is a well-known external library function used here as a negative-guidance reference (telling the agent not to call it). It would ideally carry an<!-- ecosystem: aws-lambda-go-sdk -->tag per the optional ecosystem-regression subsection of the plan, but the skill does not currently use that tagging convention.All CLI flags, env vars, language API identifiers, default-table keys, and quoted constants from all three files resolve to a docs file under
../documentation/docs/. No fabrication.Check 3 findings — regression patterns
Universal patterns scan — clean on:
--profile,--output text,--output jsonl,tcld service-account,saas-api.tmprl.cloud:7233,TEMPORAL_TLS_SERVER_CA_CERT_PATH. Zero hits.One context-dependent flag —
TEMPORAL_TLS_CLIENT_CERT_PATHandTEMPORAL_TLS_CLIENT_KEY_PATHappear in the env-var tables of all three files:references/go/integrations/lambda-workers.mdreferences/python/integrations/lambda-workers.mdreferences/typescript/integrations/lambda-workers.mdThe universal-regression table in the validation plan says these should be
TEMPORAL_TLS_CERT/TEMPORAL_TLS_KEY. However, the source-of-truth docs explicitly distinguish two namespaces:docs/cli/index.mdx:273–276documentsTEMPORAL_TLS_CA/TEMPORAL_TLS_CERT/TEMPORAL_TLS_KEYfor the CLI (temporalcommand).docs/references/client-envrionment-configuration.mdx:24–27anddocs/production-deployment/worker-deployments/serverless-workers/aws-lambda.mdx:325–326documentTEMPORAL_TLS_CLIENT_CERT_PATH/TEMPORAL_TLS_CLIENT_KEY_PATHfor the SDK client environment configuration. The Lambda Worker reads from the SDK client environment configuration, not the CLI namespace.The skill is grounded — it transcribes the env vars exactly as they appear in the cited AWS Lambda docs page (the env-var table cites lines 322–327 of that file). This is therefore not a fabrication and not a real regression; the universal regression rule itself appears to assume a CLI context. Recommendation: the regression rule in the template should be scoped to the CLI namespace, or the skill should add a comment clarifying the SDK-vs-CLI naming convention. Flagged here for visibility but does not block merge.
Check 4 findings — independent re-verification
Sampled 10 claims per file (30 total). Subagents read the authored claim, then opened the cited doc fresh and wrote what they would write from the docs, then compared.
No subtle-wrong interpretations detected. The skill faithfully reflects the cited material; a reader following the skill would take the same actions as a reader following the docs.
Check 5 findings — integration-layout audit
references/{language}/integrations/{name}.mdreferences/integrations.md:18–20; correct columns and pointersSKILL.mdeditgit diffshows zero changes toSKILL.mdgit diffshows zero changes toreferences/{go,python,typescript}/{go,python,typescript}.mdai-patterns.md(or other topical references)ai-patterns.mdeditsNo layout violations.
Check 6 findings — tone and scope audit
Pattern 1 (workaround disclosure): zero findings across all three files. Negative bullets all follow the acceptable "don't do X / do Y instead" or hard-constraint shape:
:46"Do not calllambda.Startyourself" (hard constraint, owned byRunWorker).:94DisableEagerActivities"alwaystrueand cannot be overridden" (hard constraint).:71"Don't overwrite the entire dict — mutate keys on the dataclass field..." (names supported alternative).:40"Don't useworkflowsPathon Lambda; useworkflowBundlewith pre-bundled code instead" (names supported alternative).Pattern 4 (Pre-release admonition): all three files carry the standard
> [!NOTE]block at the top with the canonical phrasing. PASS.Pattern 2/3 (minor polish, non-blocking):
:108–109— tuning bullets where sentence 2 ("Controls how long the Worker waits for in-flight Tasks after polling stops") is descriptive rationale that doesn't change generated code.:113–114— same shape forshutdown_deadline_bufferand Worker-stop-timeout tuning rules.:253— multi-sentence troubleshooting bullet (rationale sentence in the middle could be trimmed).:115— "Raising only the buffer..." re-explains the preceding three rules without adding actionable code guidance.:257— sentence 2 ("When the version is created via the UI, it is set as current automatically") describes an alternative UI path that the agent should not pursue when generating CLI code.:131— rationale clause "because the OTel SDK is compiled into the binary" is implementation narrative; the directive ("attach only the ADOT Collector layer") stands on its own.All Pattern 2/3 hits are stylistic — they could fit in a single follow-up commit but are not merge-blocking under the plan's verdict rubric.
Statistics
lambda.Start)Recommendations to maintainers
TEMPORAL_TLS_CLIENT_CERT_PATH/_KEY_PATH), which is what the cited AWS Lambda doc page uses. The universal regression rule inVALIDATION_PLAN_TEMPLATE.mdshould be tightened to "applies to CLI contexts" or include a note about the SDK-client namespace, otherwise future validations will keep flagging this.lambda.Startin Go file line 46 with an<!-- ecosystem: aws-lambda-go-sdk -->(or equivalent) comment if the skill adopts ecosystem-token tagging.End of report.